Re: [PATCH] vfio/pci: Fix NULL pointer oops in error interrupt setup handling

2016-08-03 Thread Auger Eric
Hi Alex, On 02/08/2016 22:00, Alex Williamson wrote: > There are multiple cases in vfio_pci_set_ctx_trigger_single() where > we assume we can safely read from our data pointer without actually > checking whether the user has passed any data via the count field. > VFIO_IRQ_SET_DATA_NONE in particul

[PATCH] vfio/pci: Fix NULL pointer oops in error interrupt setup handling

2016-08-02 Thread Alex Williamson
There are multiple cases in vfio_pci_set_ctx_trigger_single() where we assume we can safely read from our data pointer without actually checking whether the user has passed any data via the count field. VFIO_IRQ_SET_DATA_NONE in particular is entirely broken since we attempt to pull an int32_t file