Re: [PATCH] vfio/pci: Parallelize device open and release

2018-11-13 Thread Auger Eric
Hi Alex, On 11/13/18 5:34 PM, Alex Williamson wrote: > On Tue, 13 Nov 2018 15:42:49 +0100 > Auger Eric wrote: > >> Hi Alex, >> >> On 11/9/18 11:09 PM, Alex Williamson wrote: >>> In commit 61d792562b53 ("vfio-pci: Use mutex around open, release, and >>> remove") a mutex was added to freeze the re

Re: [PATCH] vfio/pci: Parallelize device open and release

2018-11-13 Thread Alex Williamson
On Tue, 13 Nov 2018 15:42:49 +0100 Auger Eric wrote: > Hi Alex, > > On 11/9/18 11:09 PM, Alex Williamson wrote: > > In commit 61d792562b53 ("vfio-pci: Use mutex around open, release, and > > remove") a mutex was added to freeze the refcnt for a device so that > > we can handle errors and perform

Re: [PATCH] vfio/pci: Parallelize device open and release

2018-11-13 Thread Auger Eric
Hi Alex, On 11/9/18 11:09 PM, Alex Williamson wrote: > In commit 61d792562b53 ("vfio-pci: Use mutex around open, release, and > remove") a mutex was added to freeze the refcnt for a device so that > we can handle errors and perform bus resets on final close. However, > bus resets can be rather sl

Re: [PATCH] vfio/pci: Parallelize device open and release

2018-11-10 Thread kbuild test robot
Hi Alex, I love your patch! Perhaps something to improve: [auto build test WARNING on vfio/next] [also build test WARNING on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/comm

[PATCH] vfio/pci: Parallelize device open and release

2018-11-09 Thread Alex Williamson
In commit 61d792562b53 ("vfio-pci: Use mutex around open, release, and remove") a mutex was added to freeze the refcnt for a device so that we can handle errors and perform bus resets on final close. However, bus resets can be rather slow and a global mutex here is undesirable. A per-device mutex