Re: [PATCH] vfio/pci: Support error recovery

On 12/16/2016 06:01 AM, Alex Williamson wrote: > On Thu, 15 Dec 2016 16:50:07 +0200 > "Michael S. Tsirkin" wrote: > >> On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: >>> >>> >>> On 12/15/2016 06:16 AM, Alex Williamson wrote: On Wed, 14 Dec 2016 18:24:23 +0800

Re: [PATCH] vfio/pci: Support error recovery

On 12/16/2016 06:01 AM, Alex Williamson wrote: > On Thu, 15 Dec 2016 16:50:07 +0200 > "Michael S. Tsirkin" wrote: > >> On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: >>> >>> >>> On 12/15/2016 06:16 AM, Alex Williamson wrote: On Wed, 14 Dec 2016 18:24:23 +0800 Cao jin

Re: [PATCH] vfio/pci: Support error recovery

On 12/15/2016 10:50 PM, Michael S. Tsirkin wrote: > On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: >> >> >> On 12/15/2016 06:16 AM, Alex Williamson wrote: >>> On Wed, 14 Dec 2016 18:24:23 +0800 >>> Cao jin wrote: >>> Sorry for late. after reading

Re: [PATCH] vfio/pci: Support error recovery

On 12/15/2016 10:50 PM, Michael S. Tsirkin wrote: > On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: >> >> >> On 12/15/2016 06:16 AM, Alex Williamson wrote: >>> On Wed, 14 Dec 2016 18:24:23 +0800 >>> Cao jin wrote: >>> Sorry for late. after reading all your comments, I think I

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 16:50:07 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: > > > > > > On 12/15/2016 06:16 AM, Alex Williamson wrote: > > > On Wed, 14 Dec 2016 18:24:23 +0800 > > > Cao jin wrote: > > >

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 16:50:07 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: > > > > > > On 12/15/2016 06:16 AM, Alex Williamson wrote: > > > On Wed, 14 Dec 2016 18:24:23 +0800 > > > Cao jin wrote: > > > > > >> Sorry for late. > > >> after

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 21:56:41 +0800 Cao jin wrote: > On 12/15/2016 06:16 AM, Alex Williamson wrote: > > On Wed, 14 Dec 2016 18:24:23 +0800 > > Cao jin wrote: > > > >> Sorry for late. > >> after reading all your comments, I think I will try

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 21:56:41 +0800 Cao jin wrote: > On 12/15/2016 06:16 AM, Alex Williamson wrote: > > On Wed, 14 Dec 2016 18:24:23 +0800 > > Cao jin wrote: > > > >> Sorry for late. > >> after reading all your comments, I think I will try the solution 1. > >> > >> On 12/13/2016 03:12 AM,

Re: [PATCH] vfio/pci: Support error recovery

On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: > > > On 12/15/2016 06:16 AM, Alex Williamson wrote: > > On Wed, 14 Dec 2016 18:24:23 +0800 > > Cao jin wrote: > > > >> Sorry for late. > >> after reading all your comments, I think I will try the solution 1. >

Re: [PATCH] vfio/pci: Support error recovery

On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: > > > On 12/15/2016 06:16 AM, Alex Williamson wrote: > > On Wed, 14 Dec 2016 18:24:23 +0800 > > Cao jin wrote: > > > >> Sorry for late. > >> after reading all your comments, I think I will try the solution 1. > >> > >> On 12/13/2016

Re: [PATCH] vfio/pci: Support error recovery

On 12/15/2016 06:16 AM, Alex Williamson wrote: > On Wed, 14 Dec 2016 18:24:23 +0800 > Cao jin wrote: > >> Sorry for late. >> after reading all your comments, I think I will try the solution 1. >> >> On 12/13/2016 03:12 AM, Alex Williamson wrote: >>> On Mon, 12 Dec

Re: [PATCH] vfio/pci: Support error recovery

On 12/15/2016 06:16 AM, Alex Williamson wrote: > On Wed, 14 Dec 2016 18:24:23 +0800 > Cao jin wrote: > >> Sorry for late. >> after reading all your comments, I think I will try the solution 1. >> >> On 12/13/2016 03:12 AM, Alex Williamson wrote: >>> On Mon, 12 Dec 2016 21:49:01 +0800 >>> Cao

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 01:00:06 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 14, 2016 at 03:47:43PM -0700, Alex Williamson wrote: > > On Thu, 15 Dec 2016 00:20:20 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 13, 2016 at 08:00:22PM -0700, Alex

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 01:00:06 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 14, 2016 at 03:47:43PM -0700, Alex Williamson wrote: > > On Thu, 15 Dec 2016 00:20:20 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 13, 2016 at 08:00:22PM -0700, Alex Williamson wrote: > > > > On

Re: [PATCH] vfio/pci: Support error recovery

On Wed, Dec 14, 2016 at 03:47:43PM -0700, Alex Williamson wrote: > On Thu, 15 Dec 2016 00:20:20 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 13, 2016 at 08:00:22PM -0700, Alex Williamson wrote: > > > On Wed, 14 Dec 2016 03:58:17 +0200 > > > "Michael S. Tsirkin"

Re: [PATCH] vfio/pci: Support error recovery

On Wed, Dec 14, 2016 at 03:47:43PM -0700, Alex Williamson wrote: > On Thu, 15 Dec 2016 00:20:20 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 13, 2016 at 08:00:22PM -0700, Alex Williamson wrote: > > > On Wed, 14 Dec 2016 03:58:17 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > >

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 00:20:20 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 13, 2016 at 08:00:22PM -0700, Alex Williamson wrote: > > On Wed, 14 Dec 2016 03:58:17 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 13, 2016 at 09:27:59AM -0700, Alex

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 00:20:20 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 13, 2016 at 08:00:22PM -0700, Alex Williamson wrote: > > On Wed, 14 Dec 2016 03:58:17 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Dec 13, 2016 at 09:27:59AM -0700, Alex Williamson wrote: > > > > On

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 00:25:13 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 14, 2016 at 03:16:37PM -0700, Alex Williamson wrote: > > On Wed, 14 Dec 2016 18:24:23 +0800 > > Cao jin wrote: > > > > > Sorry for late. > > > after reading all your

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 15 Dec 2016 00:25:13 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 14, 2016 at 03:16:37PM -0700, Alex Williamson wrote: > > On Wed, 14 Dec 2016 18:24:23 +0800 > > Cao jin wrote: > > > > > Sorry for late. > > > after reading all your comments, I think I will try the solution 1. > >

Re: [PATCH] vfio/pci: Support error recovery

On Wed, Dec 14, 2016 at 03:16:37PM -0700, Alex Williamson wrote: > On Wed, 14 Dec 2016 18:24:23 +0800 > Cao jin wrote: > > > Sorry for late. > > after reading all your comments, I think I will try the solution 1. > > > > On 12/13/2016 03:12 AM, Alex Williamson wrote: >

Re: [PATCH] vfio/pci: Support error recovery

On Wed, Dec 14, 2016 at 03:16:37PM -0700, Alex Williamson wrote: > On Wed, 14 Dec 2016 18:24:23 +0800 > Cao jin wrote: > > > Sorry for late. > > after reading all your comments, I think I will try the solution 1. > > > > On 12/13/2016 03:12 AM, Alex Williamson wrote: > > > On Mon, 12 Dec 2016

Re: [PATCH] vfio/pci: Support error recovery

On Tue, Dec 13, 2016 at 08:00:22PM -0700, Alex Williamson wrote: > On Wed, 14 Dec 2016 03:58:17 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 13, 2016 at 09:27:59AM -0700, Alex Williamson wrote: > > > On Tue, 13 Dec 2016 18:12:34 +0200 > > > "Michael S. Tsirkin"

Re: [PATCH] vfio/pci: Support error recovery

On Tue, Dec 13, 2016 at 08:00:22PM -0700, Alex Williamson wrote: > On Wed, 14 Dec 2016 03:58:17 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 13, 2016 at 09:27:59AM -0700, Alex Williamson wrote: > > > On Tue, 13 Dec 2016 18:12:34 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > >

Re: [PATCH] vfio/pci: Support error recovery

On Wed, 14 Dec 2016 18:24:23 +0800 Cao jin wrote: > Sorry for late. > after reading all your comments, I think I will try the solution 1. > > On 12/13/2016 03:12 AM, Alex Williamson wrote: > > On Mon, 12 Dec 2016 21:49:01 +0800 > > Cao jin

Re: [PATCH] vfio/pci: Support error recovery

On Wed, 14 Dec 2016 18:24:23 +0800 Cao jin wrote: > Sorry for late. > after reading all your comments, I think I will try the solution 1. > > On 12/13/2016 03:12 AM, Alex Williamson wrote: > > On Mon, 12 Dec 2016 21:49:01 +0800 > > Cao jin wrote: > > > >> Hi, > >> I have 2 solutions(high

Re: [PATCH] vfio/pci: Support error recovery

Sorry for late. after reading all your comments, I think I will try the solution 1. On 12/13/2016 03:12 AM, Alex Williamson wrote: > On Mon, 12 Dec 2016 21:49:01 +0800 > Cao jin wrote: > >> Hi, >> I have 2 solutions(high level design) came to me, please see if they are

Re: [PATCH] vfio/pci: Support error recovery

Sorry for late. after reading all your comments, I think I will try the solution 1. On 12/13/2016 03:12 AM, Alex Williamson wrote: > On Mon, 12 Dec 2016 21:49:01 +0800 > Cao jin wrote: > >> Hi, >> I have 2 solutions(high level design) came to me, please see if they are >> acceptable, or which

Re: [PATCH] vfio/pci: Support error recovery

On Wed, 14 Dec 2016 03:58:17 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 13, 2016 at 09:27:59AM -0700, Alex Williamson wrote: > > On Tue, 13 Dec 2016 18:12:34 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Dec 12, 2016 at 08:39:48PM -0700, Alex

Re: [PATCH] vfio/pci: Support error recovery

On Wed, 14 Dec 2016 03:58:17 +0200 "Michael S. Tsirkin" wrote: > On Tue, Dec 13, 2016 at 09:27:59AM -0700, Alex Williamson wrote: > > On Tue, 13 Dec 2016 18:12:34 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Dec 12, 2016 at 08:39:48PM -0700, Alex Williamson wrote: > > > > On

Re: [PATCH] vfio/pci: Support error recovery

On Tue, Dec 13, 2016 at 09:27:59AM -0700, Alex Williamson wrote: > On Tue, 13 Dec 2016 18:12:34 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 12, 2016 at 08:39:48PM -0700, Alex Williamson wrote: > > > On Tue, 13 Dec 2016 05:15:13 +0200 > > > "Michael S. Tsirkin"

Re: [PATCH] vfio/pci: Support error recovery

On Tue, Dec 13, 2016 at 09:27:59AM -0700, Alex Williamson wrote: > On Tue, 13 Dec 2016 18:12:34 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 12, 2016 at 08:39:48PM -0700, Alex Williamson wrote: > > > On Tue, 13 Dec 2016 05:15:13 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > >

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 13 Dec 2016 18:12:34 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 12, 2016 at 08:39:48PM -0700, Alex Williamson wrote: > > On Tue, 13 Dec 2016 05:15:13 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Dec 12, 2016 at 03:43:13PM -0700, Alex

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 13 Dec 2016 18:12:34 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 12, 2016 at 08:39:48PM -0700, Alex Williamson wrote: > > On Tue, 13 Dec 2016 05:15:13 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Dec 12, 2016 at 03:43:13PM -0700, Alex Williamson wrote: > > > > > So

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Dec 12, 2016 at 08:39:48PM -0700, Alex Williamson wrote: > On Tue, 13 Dec 2016 05:15:13 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 12, 2016 at 03:43:13PM -0700, Alex Williamson wrote: > > > > So just don't do it then. Topology must match between host and

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Dec 12, 2016 at 08:39:48PM -0700, Alex Williamson wrote: > On Tue, 13 Dec 2016 05:15:13 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 12, 2016 at 03:43:13PM -0700, Alex Williamson wrote: > > > > So just don't do it then. Topology must match between host and guest, > > > > except

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 13 Dec 2016 05:15:13 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 12, 2016 at 03:43:13PM -0700, Alex Williamson wrote: > > > So just don't do it then. Topology must match between host and guest, > > > except maybe for the case of devices with host driver (e.g. PF) >

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 13 Dec 2016 05:15:13 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 12, 2016 at 03:43:13PM -0700, Alex Williamson wrote: > > > So just don't do it then. Topology must match between host and guest, > > > except maybe for the case of devices with host driver (e.g. PF) > > > which we

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Dec 12, 2016 at 03:43:13PM -0700, Alex Williamson wrote: > > So just don't do it then. Topology must match between host and guest, > > except maybe for the case of devices with host driver (e.g. PF) > > which we might be able to synchronize against. > > We're talking about host kernel

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Dec 12, 2016 at 03:43:13PM -0700, Alex Williamson wrote: > > So just don't do it then. Topology must match between host and guest, > > except maybe for the case of devices with host driver (e.g. PF) > > which we might be able to synchronize against. > > We're talking about host kernel

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 13 Dec 2016 00:29:42 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 12, 2016 at 12:12:16PM -0700, Alex Williamson wrote: > > On Mon, 12 Dec 2016 21:49:01 +0800 > > Cao jin wrote: > > > > > Hi, > > > I have 2 solutions(high level design)

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 13 Dec 2016 00:29:42 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 12, 2016 at 12:12:16PM -0700, Alex Williamson wrote: > > On Mon, 12 Dec 2016 21:49:01 +0800 > > Cao jin wrote: > > > > > Hi, > > > I have 2 solutions(high level design) came to me, please see if they are > > >

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Dec 12, 2016 at 12:12:16PM -0700, Alex Williamson wrote: > On Mon, 12 Dec 2016 21:49:01 +0800 > Cao jin wrote: > > > Hi, > > I have 2 solutions(high level design) came to me, please see if they are > > acceptable, or which one is acceptable. Also have some

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Dec 12, 2016 at 12:12:16PM -0700, Alex Williamson wrote: > On Mon, 12 Dec 2016 21:49:01 +0800 > Cao jin wrote: > > > Hi, > > I have 2 solutions(high level design) came to me, please see if they are > > acceptable, or which one is acceptable. Also have some questions. > > > > 1. block

Re: [PATCH] vfio/pci: Support error recovery

On Mon, 12 Dec 2016 21:49:01 +0800 Cao jin wrote: > Hi, > I have 2 solutions(high level design) came to me, please see if they are > acceptable, or which one is acceptable. Also have some questions. > > 1. block guest access during host recovery > >add new field

Re: [PATCH] vfio/pci: Support error recovery

On Mon, 12 Dec 2016 21:49:01 +0800 Cao jin wrote: > Hi, > I have 2 solutions(high level design) came to me, please see if they are > acceptable, or which one is acceptable. Also have some questions. > > 1. block guest access during host recovery > >add new field error_recovering in struct

Re: [PATCH] vfio/pci: Support error recovery

Hi, I have 2 solutions(high level design) came to me, please see if they are acceptable, or which one is acceptable. Also have some questions. 1. block guest access during host recovery add new field error_recovering in struct vfio_pci_device to indicate host recovery status. aer driver in

Re: [PATCH] vfio/pci: Support error recovery

Hi, I have 2 solutions(high level design) came to me, please see if they are acceptable, or which one is acceptable. Also have some questions. 1. block guest access during host recovery add new field error_recovering in struct vfio_pci_device to indicate host recovery status. aer driver in

Re: [PATCH] vfio/pci: Support error recovery

On 12/09/2016 12:30 AM, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 10:46:59PM +0800, Cao jin wrote: >> >> >> On 12/06/2016 11:35 PM, Alex Williamson wrote: >>> On Tue, 6 Dec 2016 18:46:04 +0800 >>> Cao jin wrote: >>> On 12/06/2016 12:59 PM, Alex

Re: [PATCH] vfio/pci: Support error recovery

On 12/09/2016 12:30 AM, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 10:46:59PM +0800, Cao jin wrote: >> >> >> On 12/06/2016 11:35 PM, Alex Williamson wrote: >>> On Tue, 6 Dec 2016 18:46:04 +0800 >>> Cao jin wrote: >>> On 12/06/2016 12:59 PM, Alex Williamson wrote: > On Tue, 6

Re: [PATCH] vfio/pci: Support error recovery

On 12/08/2016 10:46 PM, Cao jin wrote: > > > On 12/06/2016 11:35 PM, Alex Williamson wrote: >> On Tue, 6 Dec 2016 18:46:04 +0800 >> Cao jin wrote: >> >>> On 12/06/2016 12:59 PM, Alex Williamson wrote: On Tue, 6 Dec 2016 05:55:28 +0200 "Michael S. Tsirkin"

Re: [PATCH] vfio/pci: Support error recovery

On 12/08/2016 10:46 PM, Cao jin wrote: > > > On 12/06/2016 11:35 PM, Alex Williamson wrote: >> On Tue, 6 Dec 2016 18:46:04 +0800 >> Cao jin wrote: >> >>> On 12/06/2016 12:59 PM, Alex Williamson wrote: On Tue, 6 Dec 2016 05:55:28 +0200 "Michael S. Tsirkin" wrote: > On

Re: [PATCH] vfio/pci: Support error recovery

On Thu, Dec 08, 2016 at 10:46:59PM +0800, Cao jin wrote: > > > On 12/06/2016 11:35 PM, Alex Williamson wrote: > > On Tue, 6 Dec 2016 18:46:04 +0800 > > Cao jin wrote: > > > >> On 12/06/2016 12:59 PM, Alex Williamson wrote: > >>> On Tue, 6 Dec 2016 05:55:28 +0200 > >>>

Re: [PATCH] vfio/pci: Support error recovery

On Thu, Dec 08, 2016 at 10:46:59PM +0800, Cao jin wrote: > > > On 12/06/2016 11:35 PM, Alex Williamson wrote: > > On Tue, 6 Dec 2016 18:46:04 +0800 > > Cao jin wrote: > > > >> On 12/06/2016 12:59 PM, Alex Williamson wrote: > >>> On Tue, 6 Dec 2016 05:55:28 +0200 > >>> "Michael S. Tsirkin"

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 11:35 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 18:46:04 +0800 > Cao jin wrote: > >> On 12/06/2016 12:59 PM, Alex Williamson wrote: >>> On Tue, 6 Dec 2016 05:55:28 +0200 >>> "Michael S. Tsirkin" wrote: >>> On Mon, Dec 05,

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 11:35 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 18:46:04 +0800 > Cao jin wrote: > >> On 12/06/2016 12:59 PM, Alex Williamson wrote: >>> On Tue, 6 Dec 2016 05:55:28 +0200 >>> "Michael S. Tsirkin" wrote: >>> On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 11:25 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 14:11:03 +0800 > Cao jin wrote: > >> On 12/06/2016 12:17 AM, Alex Williamson wrote: >>> On Mon, 5 Dec 2016 13:52:03 +0800 >>> Cao jin wrote: >>> On 12/04/2016 11:30

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 11:25 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 14:11:03 +0800 > Cao jin wrote: > >> On 12/06/2016 12:17 AM, Alex Williamson wrote: >>> On Mon, 5 Dec 2016 13:52:03 +0800 >>> Cao jin wrote: >>> On 12/04/2016 11:30 PM, Alex Williamson wrote: > On Sun, 4 Dec

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 11:35 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 18:46:04 +0800 > Cao jin wrote: > >> On 12/06/2016 12:59 PM, Alex Williamson wrote: >>> On Tue, 6 Dec 2016 05:55:28 +0200 >>> "Michael S. Tsirkin" wrote: >>> On Mon, Dec 05,

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 11:35 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 18:46:04 +0800 > Cao jin wrote: > >> On 12/06/2016 12:59 PM, Alex Williamson wrote: >>> On Tue, 6 Dec 2016 05:55:28 +0200 >>> "Michael S. Tsirkin" wrote: >>> On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 6 Dec 2016 18:46:04 +0800 Cao jin wrote: > On 12/06/2016 12:59 PM, Alex Williamson wrote: > > On Tue, 6 Dec 2016 05:55:28 +0200 > > "Michael S. Tsirkin" wrote: > > > >> On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson wrote: > >>>

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 6 Dec 2016 18:46:04 +0800 Cao jin wrote: > On 12/06/2016 12:59 PM, Alex Williamson wrote: > > On Tue, 6 Dec 2016 05:55:28 +0200 > > "Michael S. Tsirkin" wrote: > > > >> On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson wrote: > >>> If you're going to take the lead for these

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 6 Dec 2016 14:11:03 +0800 Cao jin wrote: > On 12/06/2016 12:17 AM, Alex Williamson wrote: > > On Mon, 5 Dec 2016 13:52:03 +0800 > > Cao jin wrote: > > > >> On 12/04/2016 11:30 PM, Alex Williamson wrote: > >>> On Sun, 4 Dec 2016

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 6 Dec 2016 14:11:03 +0800 Cao jin wrote: > On 12/06/2016 12:17 AM, Alex Williamson wrote: > > On Mon, 5 Dec 2016 13:52:03 +0800 > > Cao jin wrote: > > > >> On 12/04/2016 11:30 PM, Alex Williamson wrote: > >>> On Sun, 4 Dec 2016 20:16:42 +0800 > >>> Cao jin wrote: > >>> >

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 12:59 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 05:55:28 +0200 > "Michael S. Tsirkin" wrote: > >> On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson wrote: >>> If you're going to take the lead for these AER patches, I would >>> certainly suggest that

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 12:59 PM, Alex Williamson wrote: > On Tue, 6 Dec 2016 05:55:28 +0200 > "Michael S. Tsirkin" wrote: > >> On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson wrote: >>> If you're going to take the lead for these AER patches, I would >>> certainly suggest that understanding

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 11:46 AM, Michael S. Tsirkin wrote: > On Thu, Dec 01, 2016 at 09:40:23PM +0800, Cao jin wrote: >> >> >> On 12/01/2016 12:51 PM, Michael S. Tsirkin wrote: >>> On Wed, Nov 30, 2016 at 09:04:13PM -0700, Alex Williamson wrote: On Sun, 27 Nov 2016 19:34:17 +0800 Cao jin

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 11:46 AM, Michael S. Tsirkin wrote: > On Thu, Dec 01, 2016 at 09:40:23PM +0800, Cao jin wrote: >> >> >> On 12/01/2016 12:51 PM, Michael S. Tsirkin wrote: >>> On Wed, Nov 30, 2016 at 09:04:13PM -0700, Alex Williamson wrote: On Sun, 27 Nov 2016 19:34:17 +0800 Cao jin

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 12:17 AM, Alex Williamson wrote: > On Mon, 5 Dec 2016 13:52:03 +0800 > Cao jin wrote: > >> On 12/04/2016 11:30 PM, Alex Williamson wrote: >>> On Sun, 4 Dec 2016 20:16:42 +0800 >>> Cao jin wrote: >>> On 12/01/2016 10:55

Re: [PATCH] vfio/pci: Support error recovery

On 12/06/2016 12:17 AM, Alex Williamson wrote: > On Mon, 5 Dec 2016 13:52:03 +0800 > Cao jin wrote: > >> On 12/04/2016 11:30 PM, Alex Williamson wrote: >>> On Sun, 4 Dec 2016 20:16:42 +0800 >>> Cao jin wrote: >>> On 12/01/2016 10:55 PM, Alex Williamson wrote: > On Thu, 1 Dec

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 6 Dec 2016 05:55:28 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson wrote: > > If you're going to take the lead for these AER patches, I would > > certainly suggest that understanding the reasoning behind the bus reset > >

Re: [PATCH] vfio/pci: Support error recovery

On Tue, 6 Dec 2016 05:55:28 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson wrote: > > If you're going to take the lead for these AER patches, I would > > certainly suggest that understanding the reasoning behind the bus reset > > behavior is a

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson wrote: > If you're going to take the lead for these AER patches, I would > certainly suggest that understanding the reasoning behind the bus reset > behavior is a central aspect to this series. This effort has dragged > out for nearly two

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Dec 05, 2016 at 09:17:30AM -0700, Alex Williamson wrote: > If you're going to take the lead for these AER patches, I would > certainly suggest that understanding the reasoning behind the bus reset > behavior is a central aspect to this series. This effort has dragged > out for nearly two

Re: [PATCH] vfio/pci: Support error recovery

On Thu, Dec 01, 2016 at 09:40:23PM +0800, Cao jin wrote: > > > On 12/01/2016 12:51 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 30, 2016 at 09:04:13PM -0700, Alex Williamson wrote: > >> On Sun, 27 Nov 2016 19:34:17 +0800 > >> Cao jin wrote: > >> > > >>> @@ -1187,10

Re: [PATCH] vfio/pci: Support error recovery

On Thu, Dec 01, 2016 at 09:40:23PM +0800, Cao jin wrote: > > > On 12/01/2016 12:51 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 30, 2016 at 09:04:13PM -0700, Alex Williamson wrote: > >> On Sun, 27 Nov 2016 19:34:17 +0800 > >> Cao jin wrote: > >> > > >>> @@ -1187,10 +1200,30 @@ static

Re: [PATCH] vfio/pci: Support error recovery

On Mon, 5 Dec 2016 13:52:03 +0800 Cao jin wrote: > On 12/04/2016 11:30 PM, Alex Williamson wrote: > > On Sun, 4 Dec 2016 20:16:42 +0800 > > Cao jin wrote: > > > >> On 12/01/2016 10:55 PM, Alex Williamson wrote: > >>> On Thu, 1 Dec 2016

Re: [PATCH] vfio/pci: Support error recovery

On Mon, 5 Dec 2016 13:52:03 +0800 Cao jin wrote: > On 12/04/2016 11:30 PM, Alex Williamson wrote: > > On Sun, 4 Dec 2016 20:16:42 +0800 > > Cao jin wrote: > > > >> On 12/01/2016 10:55 PM, Alex Williamson wrote: > >>> On Thu, 1 Dec 2016 21:40:00 +0800 > >> > > If an AER fault

Re: [PATCH] vfio/pci: Support error recovery

On 12/04/2016 11:30 PM, Alex Williamson wrote: > On Sun, 4 Dec 2016 20:16:42 +0800 > Cao jin wrote: > >> On 12/01/2016 10:55 PM, Alex Williamson wrote: >>> On Thu, 1 Dec 2016 21:40:00 +0800 >> > If an AER fault occurs and the user doesn't do a reset, what >

Re: [PATCH] vfio/pci: Support error recovery

On 12/04/2016 11:30 PM, Alex Williamson wrote: > On Sun, 4 Dec 2016 20:16:42 +0800 > Cao jin wrote: > >> On 12/01/2016 10:55 PM, Alex Williamson wrote: >>> On Thu, 1 Dec 2016 21:40:00 +0800 >> > If an AER fault occurs and the user doesn't do a reset, what > happens when that device

Re: [PATCH] vfio/pci: Support error recovery

On Sun, 4 Dec 2016 20:16:42 +0800 Cao jin wrote: > On 12/01/2016 10:55 PM, Alex Williamson wrote: > > On Thu, 1 Dec 2016 21:40:00 +0800 > > >>> If an AER fault occurs and the user doesn't do a reset, what > >>> happens when that device is released and a host driver

Re: [PATCH] vfio/pci: Support error recovery

On Sun, 4 Dec 2016 20:16:42 +0800 Cao jin wrote: > On 12/01/2016 10:55 PM, Alex Williamson wrote: > > On Thu, 1 Dec 2016 21:40:00 +0800 > > >>> If an AER fault occurs and the user doesn't do a reset, what > >>> happens when that device is released and a host driver tries to make > >>> use of

Re: [PATCH] vfio/pci: Support error recovery

On 12/01/2016 10:55 PM, Alex Williamson wrote: > On Thu, 1 Dec 2016 21:40:00 +0800 >>> If an AER fault occurs and the user doesn't do a reset, what >>> happens when that device is released and a host driver tries to make >>> use of it? The user makes no commitment to do a reset and there are

Re: [PATCH] vfio/pci: Support error recovery

On 12/01/2016 10:55 PM, Alex Williamson wrote: > On Thu, 1 Dec 2016 21:40:00 +0800 >>> If an AER fault occurs and the user doesn't do a reset, what >>> happens when that device is released and a host driver tries to make >>> use of it? The user makes no commitment to do a reset and there are

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 1 Dec 2016 21:40:00 +0800 Cao jin wrote: > On 12/01/2016 12:04 PM, Alex Williamson wrote: > > On Sun, 27 Nov 2016 19:34:17 +0800 > > Cao jin wrote: > > > >> It is user space driver's or device-specific driver's(in guest) > >>

Re: [PATCH] vfio/pci: Support error recovery

On Thu, 1 Dec 2016 21:40:00 +0800 Cao jin wrote: > On 12/01/2016 12:04 PM, Alex Williamson wrote: > > On Sun, 27 Nov 2016 19:34:17 +0800 > > Cao jin wrote: > > > >> It is user space driver's or device-specific driver's(in guest) > >> responsbility > >> to do a serious recovery when error

Re: [PATCH] vfio/pci: Support error recovery

On 12/01/2016 12:04 PM, Alex Williamson wrote: > On Sun, 27 Nov 2016 19:34:17 +0800 > Cao jin wrote: > >> It is user space driver's or device-specific driver's(in guest) responsbility >> to do a serious recovery when error happened. Link-reset is one part of >>

Re: [PATCH] vfio/pci: Support error recovery

On 12/01/2016 12:04 PM, Alex Williamson wrote: > On Sun, 27 Nov 2016 19:34:17 +0800 > Cao jin wrote: > >> It is user space driver's or device-specific driver's(in guest) responsbility >> to do a serious recovery when error happened. Link-reset is one part of >> recovery, when pci device is

Re: [PATCH] vfio/pci: Support error recovery

On 12/01/2016 12:51 PM, Michael S. Tsirkin wrote: > On Wed, Nov 30, 2016 at 09:04:13PM -0700, Alex Williamson wrote: >> On Sun, 27 Nov 2016 19:34:17 +0800 >> Cao jin wrote: >> >>> @@ -1187,10 +1200,30 @@ static pci_ers_result_t >>> vfio_pci_aer_err_detected(struct

Re: [PATCH] vfio/pci: Support error recovery

On 12/01/2016 12:51 PM, Michael S. Tsirkin wrote: > On Wed, Nov 30, 2016 at 09:04:13PM -0700, Alex Williamson wrote: >> On Sun, 27 Nov 2016 19:34:17 +0800 >> Cao jin wrote: >> >>> @@ -1187,10 +1200,30 @@ static pci_ers_result_t >>> vfio_pci_aer_err_detected(struct pci_dev *pdev, >>>

Re: [PATCH] vfio/pci: Support error recovery

On 11/30/2016 09:46 AM, Michael S. Tsirkin wrote: > On Mon, Nov 28, 2016 at 05:32:15PM +0800, Cao jin wrote: >> >> >>> + if (severity == AER_FATAL && strcmp(dev->driver->name, "vfio-pci")) { >>> >>> You really want some flag in the device, or something similar. >>> Also, how do we know

Re: [PATCH] vfio/pci: Support error recovery

On 11/30/2016 09:46 AM, Michael S. Tsirkin wrote: > On Mon, Nov 28, 2016 at 05:32:15PM +0800, Cao jin wrote: >> >> >>> + if (severity == AER_FATAL && strcmp(dev->driver->name, "vfio-pci")) { >>> >>> You really want some flag in the device, or something similar. >>> Also, how do we know

Re: [PATCH] vfio/pci: Support error recovery

On Wed, Nov 30, 2016 at 09:04:13PM -0700, Alex Williamson wrote: > On Sun, 27 Nov 2016 19:34:17 +0800 > Cao jin wrote: > > > It is user space driver's or device-specific driver's(in guest) > > responsbility > > to do a serious recovery when error happened. Link-reset

Re: [PATCH] vfio/pci: Support error recovery

On Wed, Nov 30, 2016 at 09:04:13PM -0700, Alex Williamson wrote: > On Sun, 27 Nov 2016 19:34:17 +0800 > Cao jin wrote: > > > It is user space driver's or device-specific driver's(in guest) > > responsbility > > to do a serious recovery when error happened. Link-reset is one part of > >

Re: [PATCH] vfio/pci: Support error recovery

On Sun, 27 Nov 2016 19:34:17 +0800 Cao jin wrote: > It is user space driver's or device-specific driver's(in guest) responsbility > to do a serious recovery when error happened. Link-reset is one part of > recovery, when pci device is assigned to VM via vfio, link-reset

Re: [PATCH] vfio/pci: Support error recovery

On Sun, 27 Nov 2016 19:34:17 +0800 Cao jin wrote: > It is user space driver's or device-specific driver's(in guest) responsbility > to do a serious recovery when error happened. Link-reset is one part of > recovery, when pci device is assigned to VM via vfio, link-reset will do > twice in host &

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Nov 28, 2016 at 05:32:15PM +0800, Cao jin wrote: > > > On 11/28/2016 11:00 AM, Michael S. Tsirkin wrote: > > On Sun, Nov 27, 2016 at 07:34:17PM +0800, Cao jin wrote: > > > It is user space driver's or device-specific driver's(in guest) > > > responsbility > > > to do a serious recovery

Re: [PATCH] vfio/pci: Support error recovery

On Mon, Nov 28, 2016 at 05:32:15PM +0800, Cao jin wrote: > > > On 11/28/2016 11:00 AM, Michael S. Tsirkin wrote: > > On Sun, Nov 27, 2016 at 07:34:17PM +0800, Cao jin wrote: > > > It is user space driver's or device-specific driver's(in guest) > > > responsbility > > > to do a serious recovery

Re: [PATCH] vfio/pci: Support error recovery

On 11/28/2016 11:00 AM, Michael S. Tsirkin wrote: On Sun, Nov 27, 2016 at 07:34:17PM +0800, Cao jin wrote: It is user space driver's or device-specific driver's(in guest) responsbility to do a serious recovery when error happened. Link-reset is one part of recovery, when pci device is

Re: [PATCH] vfio/pci: Support error recovery

On 11/28/2016 11:00 AM, Michael S. Tsirkin wrote: On Sun, Nov 27, 2016 at 07:34:17PM +0800, Cao jin wrote: It is user space driver's or device-specific driver's(in guest) responsbility to do a serious recovery when error happened. Link-reset is one part of recovery, when pci device is

  1   2   >