Re: [PATCH] vfio: fix vfio_info_cap_add/shift

2016-11-21 Thread Alex Williamson
On Mon, 21 Nov 2016 07:21:02 +0100 Eric Auger wrote: > Capability header next field is an offset relative to the start of > the INFO buffer. tmp->next is assigned the proper value but iterations > implemented in vfio_info_cap_add and vfio_info_cap_shift use next > as an offset between the headers

Re: [PATCH] vfio: fix vfio_info_cap_add/shift

2016-11-21 Thread David Hildenbrand
Am 21.11.2016 um 07:21 schrieb Eric Auger: Capability header next field is an offset relative to the start of the INFO buffer. tmp->next is assigned the proper value but iterations implemented in vfio_info_cap_add and vfio_info_cap_shift use next as an offset between the headers. When coping with

[PATCH] vfio: fix vfio_info_cap_add/shift

2016-11-20 Thread Eric Auger
Capability header next field is an offset relative to the start of the INFO buffer. tmp->next is assigned the proper value but iterations implemented in vfio_info_cap_add and vfio_info_cap_shift use next as an offset between the headers. When coping with multiple capabilities this leads to an Oops.