Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-08 Thread Michael Ellerman
Alex Williamson writes: ... > > Numbering options for clarity: > > 1) >> ccflags-y += -I$(src) >> would add the header search path for all files in drivers/vfio/pci/ >> whereas only the drivers/vfio/pci/vfio_pci_nvlink2.c needs it. >> > > 2) >> CFLAGS_vfio_pci_nvlink2.o += -I$(src) >> is a bit be

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Masahiro Yamada
On Tue, Jan 8, 2019 at 11:59 AM Alexey Kardashevskiy wrote: > > > > On 08/01/2019 13:38, Masahiro Yamada wrote: > > On Tue, Jan 8, 2019 at 11:22 AM Alexey Kardashevskiy wrote: > >> > >> > >> > >> On 08/01/2019 11:24, Alex Williamson wrote: > >>> On Tue, 8 Jan 2019 10:52:43 +1100 > >>> Alexey Kard

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Alexey Kardashevskiy
On 08/01/2019 13:38, Masahiro Yamada wrote: > On Tue, Jan 8, 2019 at 11:22 AM Alexey Kardashevskiy wrote: >> >> >> >> On 08/01/2019 11:24, Alex Williamson wrote: >>> On Tue, 8 Jan 2019 10:52:43 +1100 >>> Alexey Kardashevskiy wrote: >>> On 08/01/2019 07:13, Alex Williamson wrote: > On

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Masahiro Yamada
On Tue, Jan 8, 2019 at 11:22 AM Alexey Kardashevskiy wrote: > > > > On 08/01/2019 11:24, Alex Williamson wrote: > > On Tue, 8 Jan 2019 10:52:43 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 08/01/2019 07:13, Alex Williamson wrote: > >>> On Mon, 7 Jan 2019 20:39:19 +0900 > >>> Masahiro Yamada

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Alexey Kardashevskiy
On 08/01/2019 11:24, Alex Williamson wrote: > On Tue, 8 Jan 2019 10:52:43 +1100 > Alexey Kardashevskiy wrote: > >> On 08/01/2019 07:13, Alex Williamson wrote: >>> On Mon, 7 Jan 2019 20:39:19 +0900 >>> Masahiro Yamada wrote: >>> On Mon, Jan 7, 2019 at 8:09 PM Cornelia Huck wrote: >>

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Alex Williamson
On Tue, 8 Jan 2019 10:52:43 +1100 Alexey Kardashevskiy wrote: > On 08/01/2019 07:13, Alex Williamson wrote: > > On Mon, 7 Jan 2019 20:39:19 +0900 > > Masahiro Yamada wrote: > > > >> On Mon, Jan 7, 2019 at 8:09 PM Cornelia Huck wrote: > >>> > >>> On Mon, 7 Jan 2019 19:12:10 +0900 > >>> Masa

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Alexey Kardashevskiy
On 08/01/2019 07:13, Alex Williamson wrote: > On Mon, 7 Jan 2019 20:39:19 +0900 > Masahiro Yamada wrote: > >> On Mon, Jan 7, 2019 at 8:09 PM Cornelia Huck wrote: >>> >>> On Mon, 7 Jan 2019 19:12:10 +0900 >>> Masahiro Yamada wrote: >>> On Mon, Jan 7, 2019 at 6:18 PM Michael Ellerman

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Alex Williamson
On Mon, 7 Jan 2019 20:39:19 +0900 Masahiro Yamada wrote: > On Mon, Jan 7, 2019 at 8:09 PM Cornelia Huck wrote: > > > > On Mon, 7 Jan 2019 19:12:10 +0900 > > Masahiro Yamada wrote: > > > > > On Mon, Jan 7, 2019 at 6:18 PM Michael Ellerman > > > wrote: > > > > > > > > Laura Abbott writes:

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Laura Abbott
On 1/7/19 12:58 AM, Michael Ellerman wrote: Laura Abbott writes: Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver") introduced a trace.h file in the local directory but missed adding the local include path, resulting in compilation failures with tracepoints: In fi

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Masahiro Yamada
On Mon, Jan 7, 2019 at 8:09 PM Cornelia Huck wrote: > > On Mon, 7 Jan 2019 19:12:10 +0900 > Masahiro Yamada wrote: > > > On Mon, Jan 7, 2019 at 6:18 PM Michael Ellerman wrote: > > > > > > Laura Abbott writes: > > > > Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] > > > > s

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Cornelia Huck
On Fri, 4 Jan 2019 11:57:14 -0800 Laura Abbott wrote: > Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] > subdriver") introduced a trace.h file in the local directory but > missed adding the local include path, resulting in compilation > failures with tracepoints: > > In fi

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Cornelia Huck
On Mon, 7 Jan 2019 19:12:10 +0900 Masahiro Yamada wrote: > On Mon, Jan 7, 2019 at 6:18 PM Michael Ellerman wrote: > > > > Laura Abbott writes: > > > Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] > > > subdriver") introduced a trace.h file in the local directory but > >

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Masahiro Yamada
On Mon, Jan 7, 2019 at 6:18 PM Michael Ellerman wrote: > > Laura Abbott writes: > > Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] > > subdriver") introduced a trace.h file in the local directory but > > missed adding the local include path, resulting in compilation > > fail

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-07 Thread Michael Ellerman
Laura Abbott writes: > Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] > subdriver") introduced a trace.h file in the local directory but > missed adding the local include path, resulting in compilation > failures with tracepoints: > > In file included from drivers/vfio/pci/tr

Re: [PATCH] vfio_pci: Add local source directory as include

2019-01-06 Thread Alexey Kardashevskiy
On 05/01/2019 06:57, Laura Abbott wrote: > Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] > subdriver") introduced a trace.h file in the local directory but > missed adding the local include path, resulting in compilation > failures with tracepoints: > > In file included f

[PATCH] vfio_pci: Add local source directory as include

2019-01-04 Thread Laura Abbott
Commit 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver") introduced a trace.h file in the local directory but missed adding the local include path, resulting in compilation failures with tracepoints: In file included from drivers/vfio/pci/trace.h:102, from