Re: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp

2013-06-18 Thread Hector Palacios
On 06/18/2013 10:32 AM, maxime.rip...@free-electrons.com wrote: Hi Hector, On Fri, Jun 07, 2013 at 11:02:28AM +0200, maxime.rip...@free-electrons.com wrote: On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote: For a combination of 18bit LCD data bus width and a color mode of

Re: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp

2013-06-18 Thread maxime.rip...@free-electrons.com
Hi Hector, On Fri, Jun 07, 2013 at 11:02:28AM +0200, maxime.rip...@free-electrons.com wrote: > On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote: > > For a combination of 18bit LCD data bus width and a color > > mode of 32bpp, the driver was setting the color mapping to > > rgb666,

Re: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp

2013-06-18 Thread maxime.rip...@free-electrons.com
Hi Hector, On Fri, Jun 07, 2013 at 11:02:28AM +0200, maxime.rip...@free-electrons.com wrote: On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote: For a combination of 18bit LCD data bus width and a color mode of 32bpp, the driver was setting the color mapping to rgb666, which

Re: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp

2013-06-18 Thread Hector Palacios
On 06/18/2013 10:32 AM, maxime.rip...@free-electrons.com wrote: Hi Hector, On Fri, Jun 07, 2013 at 11:02:28AM +0200, maxime.rip...@free-electrons.com wrote: On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote: For a combination of 18bit LCD data bus width and a color mode of

Re: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp

2013-06-07 Thread maxime.rip...@free-electrons.com
Hi Hector, On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote: > For a combination of 18bit LCD data bus width and a color > mode of 32bpp, the driver was setting the color mapping to > rgb666, which is wrong, as the color in memory realy has an > rgb888 layout. > > This patch also

[PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp

2013-06-07 Thread Hector Palacios
For a combination of 18bit LCD data bus width and a color mode of 32bpp, the driver was setting the color mapping to rgb666, which is wrong, as the color in memory realy has an rgb888 layout. This patch also removes the setting of flag CTRL_DF24 that makes the driver dimiss the upper 2 bits when

[PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp

2013-06-07 Thread Hector Palacios
For a combination of 18bit LCD data bus width and a color mode of 32bpp, the driver was setting the color mapping to rgb666, which is wrong, as the color in memory realy has an rgb888 layout. This patch also removes the setting of flag CTRL_DF24 that makes the driver dimiss the upper 2 bits when

Re: [PATCH] video: mxsfb: fix color settings for 18bit data bus and 32bpp

2013-06-07 Thread maxime.rip...@free-electrons.com
Hi Hector, On Fri, Jun 07, 2013 at 10:10:39AM +0200, Hector Palacios wrote: For a combination of 18bit LCD data bus width and a color mode of 32bpp, the driver was setting the color mapping to rgb666, which is wrong, as the color in memory realy has an rgb888 layout. This patch also