Re: [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

2017-08-01 Thread Bartlomiej Zolnierkiewicz
On Friday, July 07, 2017 08:24:16 PM Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position

Re: [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

2017-08-01 Thread Bartlomiej Zolnierkiewicz
On Friday, July 07, 2017 08:24:16 PM Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position

Re: [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

2017-07-16 Thread Gustavo A. R. Silva
On 07/10/2017 02:29 AM, Michal Simek wrote: On 8.7.2017 03:24, Gustavo A. R. Silva wrote: These structures are only used to copy into other structures, so declare them as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@

Re: [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

2017-07-16 Thread Gustavo A. R. Silva
On 07/10/2017 02:29 AM, Michal Simek wrote: On 8.7.2017 03:24, Gustavo A. R. Silva wrote: These structures are only used to copy into other structures, so declare them as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@

Re: [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

2017-07-10 Thread Michal Simek
On 8.7.2017 03:24, Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static

Re: [PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

2017-07-10 Thread Michal Simek
On 8.7.2017 03:24, Gustavo A. R. Silva wrote: > These structures are only used to copy into other structures, > so declare them as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static

[PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

2017-07-07 Thread Gustavo A. R. Silva
These structures are only used to copy into other structures, so declare them as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct fb_fix_screeninfo i@p = { ... }; @ok@ identifier r.i;

[PATCH] video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

2017-07-07 Thread Gustavo A. R. Silva
These structures are only used to copy into other structures, so declare them as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct fb_fix_screeninfo i@p = { ... }; @ok@ identifier r.i;