Re: [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-20 Thread Chen Gang
On 08/20/2014 08:01 AM, Chen Gang wrote: > > By the way, at present, I use Qemu as user mode program, is there common > test with both Qemu and KVM/Xen? And is a PC enough for the common test? > Oh, I find Qemu have "make check" just like gcc/binutils, so for each of my patch, next, shall run "./

Re: [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-19 Thread Chen Gang
By the way, at present, I use Qemu as user mode program, is there common test with both Qemu and KVM/Xen? And is a PC enough for the common test? Thanks. On 08/20/2014 07:58 AM, Chen Gang wrote: > On 08/19/2014 11:49 PM, Paolo Bonzini wrote: >> Il 19/08/2014 17:44, Chen Gang ha scritto: Hel

Re: [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-19 Thread Chen Gang
On 08/19/2014 11:49 PM, Paolo Bonzini wrote: > Il 19/08/2014 17:44, Chen Gang ha scritto: >> > Hello maintainers: >> > >> > Please help check this patch, when you have time. > Hi, it's already on its way to 3.17-rc2, but I first have to run a bunch > of tests. OK, thanks. Also can let me try the

Re: [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-19 Thread Paolo Bonzini
Il 19/08/2014 17:44, Chen Gang ha scritto: > Hello maintainers: > > Please help check this patch, when you have time. Hi, it's already on its way to 3.17-rc2, but I first have to run a bunch of tests. Paolo > Thanks. > > On 08/08/2014 11:37 PM, Chen Gang wrote: >> As a generic function, deassi

Re: [PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-19 Thread Chen Gang
Hello maintainers: Please help check this patch, when you have time. Thanks. On 08/08/2014 11:37 PM, Chen Gang wrote: > As a generic function, deassign_guest_irq() assumes it can be called > even if assign_guest_irq() is not be called successfully (which can be > triggered by ioctl from user mod

[PATCH] virt/kvm/assigned-dev.c: Set 'dev->irq_source_id' to '-1' after free it

2014-08-08 Thread Chen Gang
As a generic function, deassign_guest_irq() assumes it can be called even if assign_guest_irq() is not be called successfully (which can be triggered by ioctl from user mode, indirectly). So for assign_guest_irq() failure process, need set 'dev->irq_source_id' to -1 after free 'dev->irq_source_id'