Re: [PATCH] virtio: console: Unlock vqs while freeing buffers

2016-10-25 Thread Michael S. Tsirkin
On Tue, Oct 25, 2016 at 12:48:03PM +0530, Amit Shah wrote: > On (Tue) 11 Oct 2016 [12:05:15], Matt Redfearn wrote: > > Commit c6017e793b93 ("virtio: console: add locks around buffer removal > > in port unplug path") added locking around the freeing of buffers in the > > vq. However, when

Re: [PATCH] virtio: console: Unlock vqs while freeing buffers

2016-10-25 Thread Michael S. Tsirkin
On Tue, Oct 25, 2016 at 12:48:03PM +0530, Amit Shah wrote: > On (Tue) 11 Oct 2016 [12:05:15], Matt Redfearn wrote: > > Commit c6017e793b93 ("virtio: console: add locks around buffer removal > > in port unplug path") added locking around the freeing of buffers in the > > vq. However, when

Re: [PATCH] virtio: console: Unlock vqs while freeing buffers

2016-10-25 Thread Amit Shah
On (Tue) 11 Oct 2016 [12:05:15], Matt Redfearn wrote: > Commit c6017e793b93 ("virtio: console: add locks around buffer removal > in port unplug path") added locking around the freeing of buffers in the > vq. However, when free_buf() is called with can_sleep = true and rproc > is enabled, it calls

Re: [PATCH] virtio: console: Unlock vqs while freeing buffers

2016-10-25 Thread Amit Shah
On (Tue) 11 Oct 2016 [12:05:15], Matt Redfearn wrote: > Commit c6017e793b93 ("virtio: console: add locks around buffer removal > in port unplug path") added locking around the freeing of buffers in the > vq. However, when free_buf() is called with can_sleep = true and rproc > is enabled, it calls

[PATCH] virtio: console: Unlock vqs while freeing buffers

2016-10-11 Thread Matt Redfearn
Commit c6017e793b93 ("virtio: console: add locks around buffer removal in port unplug path") added locking around the freeing of buffers in the vq. However, when free_buf() is called with can_sleep = true and rproc is enabled, it calls dma_free_coherent() directly, requiring interrupts to be

[PATCH] virtio: console: Unlock vqs while freeing buffers

2016-10-11 Thread Matt Redfearn
Commit c6017e793b93 ("virtio: console: add locks around buffer removal in port unplug path") added locking around the freeing of buffers in the vq. However, when free_buf() is called with can_sleep = true and rproc is enabled, it calls dma_free_coherent() directly, requiring interrupts to be