Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-04-03 Thread Rusty Russell
Stefan Hajnoczi writes: > On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o wrote: >> On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: >>> >>> It's head of my virtio-next tree. >> >> Hey Rusty, >> >> While we have your attention --- what's your opinion about adding TRIM >> support to

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-04-03 Thread Rusty Russell
Stefan Hajnoczi stefa...@gmail.com writes: On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o ty...@mit.edu wrote: On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: It's head of my virtio-next tree. Hey Rusty, While we have your attention --- what's your opinion about adding TRIM

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-04-01 Thread Stefan Hajnoczi
On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o wrote: > On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: >> >> It's head of my virtio-next tree. > > Hey Rusty, > > While we have your attention --- what's your opinion about adding TRIM > support to virtio-blk. I understand that

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-04-01 Thread Stefan Hajnoczi
On Tue, Apr 1, 2014 at 4:27 AM, Theodore Ts'o ty...@mit.edu wrote: On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: It's head of my virtio-next tree. Hey Rusty, While we have your attention --- what's your opinion about adding TRIM support to virtio-blk. I understand that

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-31 Thread Theodore Ts'o
On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: > > It's head of my virtio-next tree. Hey Rusty, While we have your attention --- what's your opinion about adding TRIM support to virtio-blk. I understand that you're starting an OASIS standardization process for virtio --- what

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-31 Thread Theodore Ts'o
On Mon, Mar 31, 2014 at 02:22:50PM +1030, Rusty Russell wrote: It's head of my virtio-next tree. Hey Rusty, While we have your attention --- what's your opinion about adding TRIM support to virtio-blk. I understand that you're starting an OASIS standardization process for virtio --- what

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-30 Thread Rusty Russell
Venkatesh Srinivas writes: > On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas > wrote: >>> And I rewrote it substantially, mainly to take >>> VIRTIO_RING_F_INDIRECT_DESC into account. >>> >>> As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't >>> have made a change. This

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-30 Thread Rusty Russell
Venkatesh Srinivas venkate...@google.com writes: On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas venkate...@google.com wrote: And I rewrote it substantially, mainly to take VIRTIO_RING_F_INDIRECT_DESC into account. As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-25 Thread Venkatesh Srinivas
On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas wrote: >> And I rewrote it substantially, mainly to take >> VIRTIO_RING_F_INDIRECT_DESC into account. >> >> As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't >> have made a change. This version does (since QEMU also offers >>

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-25 Thread Venkatesh Srinivas
On Wed, Mar 19, 2014 at 10:48 AM, Venkatesh Srinivas venkate...@google.com wrote: And I rewrote it substantially, mainly to take VIRTIO_RING_F_INDIRECT_DESC into account. As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't have made a change. This version does (since QEMU

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-19 Thread Venkatesh Srinivas
> And I rewrote it substantially, mainly to take > VIRTIO_RING_F_INDIRECT_DESC into account. > > As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't > have made a change. This version does (since QEMU also offers > VIRTIO_RING_F_INDIRECT_DESC. That divide-by-2 produced the same

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-19 Thread Rusty Russell
ty...@mit.edu writes: > On Mon, Mar 17, 2014 at 11:12:15AM +1030, Rusty Russell wrote: >> >> Note that with indirect descriptors (which is supported by Almost >> Everyone), we can actually use the full index, so this value is a bit >> pessimistic. But it's OK as a starting point. > > So is this

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-19 Thread Rusty Russell
ty...@mit.edu writes: On Mon, Mar 17, 2014 at 11:12:15AM +1030, Rusty Russell wrote: Note that with indirect descriptors (which is supported by Almost Everyone), we can actually use the full index, so this value is a bit pessimistic. But it's OK as a starting point. So is this something

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-19 Thread Venkatesh Srinivas
And I rewrote it substantially, mainly to take VIRTIO_RING_F_INDIRECT_DESC into account. As QEMU sets the vq size for PCI to 128, Venkatash's patch wouldn't have made a change. This version does (since QEMU also offers VIRTIO_RING_F_INDIRECT_DESC. That divide-by-2 produced the same queue

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-16 Thread tytso
On Mon, Mar 17, 2014 at 11:12:15AM +1030, Rusty Russell wrote: > > Note that with indirect descriptors (which is supported by Almost > Everyone), we can actually use the full index, so this value is a bit > pessimistic. But it's OK as a starting point. So is this something that can go upstream

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-16 Thread Rusty Russell
Theodore Ts'o writes: > The current virtio block sets a queue depth of 64, which is > insufficient for very fast devices. It has been demonstrated that > with a high IOPS device, using a queue depth of 256 can double the > IOPS which can be sustained. > > As suggested by Venkatash Srinivas, set

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-16 Thread Rusty Russell
Theodore Ts'o ty...@mit.edu writes: The current virtio block sets a queue depth of 64, which is insufficient for very fast devices. It has been demonstrated that with a high IOPS device, using a queue depth of 256 can double the IOPS which can be sustained. As suggested by Venkatash

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-16 Thread tytso
On Mon, Mar 17, 2014 at 11:12:15AM +1030, Rusty Russell wrote: Note that with indirect descriptors (which is supported by Almost Everyone), we can actually use the full index, so this value is a bit pessimistic. But it's OK as a starting point. So is this something that can go upstream with

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-15 Thread Theodore Ts'o
On Sat, Mar 15, 2014 at 06:57:23AM -0700, Christoph Hellwig wrote: > I don't think this should be a module parameter. The default sizing > should be based of the parameters of the actual virtqueue, and if we > want to allow tuning it it should be by a sysfs attribute, preferable > using the same

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-15 Thread Christoph Hellwig
On Fri, Mar 14, 2014 at 11:34:31PM -0400, Theodore Ts'o wrote: > The current virtio block sets a queue depth of 64, which is > insufficient for very fast devices. It has been demonstrated that > with a high IOPS device, using a queue depth of 256 can double the > IOPS which can be sustained. > >

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-15 Thread Theodore Ts'o
On Sat, Mar 15, 2014 at 06:57:01AM -0400, Konrad Rzeszutek Wilk wrote: > >+pr_info("%s: using queue depth %d\n", vblk->disk->disk_name, > >+virtio_mq_reg.queue_depth); > > Isn't that visible from sysfs? As near as I can tell, it's not. I haven't been able to find anything that

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-15 Thread Konrad Rzeszutek Wilk
On March 14, 2014 11:34:31 PM EDT, Theodore Ts'o wrote: >The current virtio block sets a queue depth of 64, which is >insufficient for very fast devices. It has been demonstrated that >with a high IOPS device, using a queue depth of 256 can double the >IOPS which can be sustained. > >As

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-15 Thread Konrad Rzeszutek Wilk
On March 14, 2014 11:34:31 PM EDT, Theodore Ts'o ty...@mit.edu wrote: The current virtio block sets a queue depth of 64, which is insufficient for very fast devices. It has been demonstrated that with a high IOPS device, using a queue depth of 256 can double the IOPS which can be sustained. As

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-15 Thread Theodore Ts'o
On Sat, Mar 15, 2014 at 06:57:01AM -0400, Konrad Rzeszutek Wilk wrote: +pr_info(%s: using queue depth %d\n, vblk-disk-disk_name, +virtio_mq_reg.queue_depth); Isn't that visible from sysfs? As near as I can tell, it's not. I haven't been able to find anything that either

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-15 Thread Christoph Hellwig
On Fri, Mar 14, 2014 at 11:34:31PM -0400, Theodore Ts'o wrote: The current virtio block sets a queue depth of 64, which is insufficient for very fast devices. It has been demonstrated that with a high IOPS device, using a queue depth of 256 can double the IOPS which can be sustained. As

Re: [PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-15 Thread Theodore Ts'o
On Sat, Mar 15, 2014 at 06:57:23AM -0700, Christoph Hellwig wrote: I don't think this should be a module parameter. The default sizing should be based of the parameters of the actual virtqueue, and if we want to allow tuning it it should be by a sysfs attribute, preferable using the same

[PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-14 Thread Theodore Ts'o
The current virtio block sets a queue depth of 64, which is insufficient for very fast devices. It has been demonstrated that with a high IOPS device, using a queue depth of 256 can double the IOPS which can be sustained. As suggested by Venkatash Srinivas, set the queue depth by default to be

[PATCH] virtio-blk: make the queue depth the max supportable by the hypervisor

2014-03-14 Thread Theodore Ts'o
The current virtio block sets a queue depth of 64, which is insufficient for very fast devices. It has been demonstrated that with a high IOPS device, using a queue depth of 256 can double the IOPS which can be sustained. As suggested by Venkatash Srinivas, set the queue depth by default to be