Re: [PATCH] virtio-net: hold netdev_lock when pausing rx

2025-04-10 Thread Michael S. Tsirkin
On Thu, Apr 10, 2025 at 02:05:57PM +0700, Bui Quang Minh wrote: > When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call > napi_disable() on the receive queue's napi. In delayed refill_work, it > also calls napi_disable() on the receive queue's napi. When > napi_disable() is called on an a

Re: [PATCH] virtio-net: hold netdev_lock when pausing rx

2025-04-10 Thread Bui Quang Minh
On 4/10/25 14:58, Michael S. Tsirkin wrote: On Thu, Apr 10, 2025 at 02:05:57PM +0700, Bui Quang Minh wrote: When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call napi_disable() on the receive queue's napi. In delayed refill_work, it also calls napi_disable() on the receive queue's napi

[PATCH] virtio-net: hold netdev_lock when pausing rx

2025-04-10 Thread Bui Quang Minh
When pausing rx (e.g. set up xdp, xsk pool, rx resize), we call napi_disable() on the receive queue's napi. In delayed refill_work, it also calls napi_disable() on the receive queue's napi. When napi_disable() is called on an already disabled napi, it will sleep in napi_disable_locked while still