Re: [PATCH] virtio_balloon: drop virtio_balloon_stat_modern

2015-04-14 Thread Rusty Russell
Cornelia Huck writes: > On Tue, 14 Apr 2015 12:01:13 +0200 > "Michael S. Tsirkin" wrote: > >> Looks like we are better off sticking with the misaligned stat struct, >> to reduce the amount of virtio 1 specific code in balloon. So let's do >> it. >> >> Add a detailed comment to reduce the chance

Re: [PATCH] virtio_balloon: drop virtio_balloon_stat_modern

2015-04-14 Thread Cornelia Huck
On Tue, 14 Apr 2015 12:01:13 +0200 "Michael S. Tsirkin" wrote: > Looks like we are better off sticking with the misaligned stat struct, > to reduce the amount of virtio 1 specific code in balloon. So let's do > it. > > Add a detailed comment to reduce the chance people copy this bad example. >

[PATCH] virtio_balloon: drop virtio_balloon_stat_modern

2015-04-14 Thread Michael S. Tsirkin
Looks like we are better off sticking with the misaligned stat struct, to reduce the amount of virtio 1 specific code in balloon. So let's do it. Add a detailed comment to reduce the chance people copy this bad example. This also fixes a bug on BE architectures: tag should use cpu_to_le16, not c