Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-15 Thread Christoph Hellwig
On Wed, Apr 14, 2021 at 09:44:35AM +0100, Stefan Hajnoczi wrote: > On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote: > > A note to the virtio committee: eMMC is the worst of all the currently > > active storage standards by a large margin. It defines very strange > > ad-hoc

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-15 Thread Christoph Hellwig
On Mon, Apr 12, 2021 at 08:00:24AM -0400, Michael S. Tsirkin wrote: > On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote: > > A note to the virtio committee: eMMC is the worst of all the currently > > active storage standards by a large margin. It defines very strange > > ad-hoc

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-14 Thread Enrico Granata
First and foremost thanks for the feedback on the code. I will send out an up-to-date patch with those comments addressed ASAP As for the broader issue, I am definitely happy to incorporate any feedback and work to improve the spec, but looking at embedded storage devices both eMMC and UFS seem

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-14 Thread Stefan Hajnoczi
On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote: > A note to the virtio committee: eMMC is the worst of all the currently > active storage standards by a large margin. It defines very strange > ad-hoc interfaces that expose very specific internals and often provides > very poor

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-12 Thread Michael S. Tsirkin
On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote: > A note to the virtio committee: eMMC is the worst of all the currently > active storage standards by a large margin. It defines very strange > ad-hoc interfaces that expose very specific internals and often provides > very poor

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-12 Thread Christoph Hellwig
A note to the virtio committee: eMMC is the worst of all the currently active storage standards by a large margin. It defines very strange ad-hoc interfaces that expose very specific internals and often provides very poor abstractions. It would be great it you could reach out to the wider

Re: [PATCH] virtio_blk: Add support for lifetime feature

2021-04-12 Thread Stefan Hajnoczi
On Tue, Mar 30, 2021 at 11:16:02PM +, Enrico Granata wrote: > The VirtIO TC has adopted a new feature in virtio-blk enabling > discovery of lifetime information. > > This commit adds support for the VIRTIO_BLK_T_LIFETIME command > to the virtio_blk driver, and adds two new attributes to the >

[PATCH] virtio_blk: Add support for lifetime feature

2021-03-30 Thread Enrico Granata
The VirtIO TC has adopted a new feature in virtio-blk enabling discovery of lifetime information. This commit adds support for the VIRTIO_BLK_T_LIFETIME command to the virtio_blk driver, and adds two new attributes to the sysfs entry for virtio_blk: * pre_eol_info * life_time which are defined