On Mon, Sep 08, 2014 at 10:15:57PM +0200, Christoph Hellwig wrote:
> On Mon, Sep 08, 2014 at 11:18:30AM +0300, Michael S. Tsirkin wrote:
> > Could you respond to Ming Lei's mail, who benchmarked the patch, please?
>
> I don't really have any additional data or disagreement, not sure what
> I shoul
On Wed, Sep 10, 2014 at 11:18 PM, Paolo Bonzini wrote:
> Il 07/09/2014 12:32, Ming Lei ha scritto:
>> It is a good idea to disable SG merge for vq incapable of indirect because
>> there are very limited direct descriptors.
>
> I think you mean _enabling_ SG merge if indirect descriptors are not th
Il 07/09/2014 12:32, Ming Lei ha scritto:
> It is a good idea to disable SG merge for vq incapable of indirect because
> there are very limited direct descriptors.
I think you mean _enabling_ SG merge if indirect descriptors are not there.
> For vq capable of indirect, it should be better to not
On Mon, Sep 08, 2014 at 11:18:30AM +0300, Michael S. Tsirkin wrote:
> Could you respond to Ming Lei's mail, who benchmarked the patch, please?
I don't really have any additional data or disagreement, not sure what
I should respond there.
--
To unsubscribe from this list: send the line "unsubscribe
Il 07/09/2014 13:41, Michael S. Tsirkin ha scritto:
> On Sat, Sep 06, 2014 at 04:09:54PM -0700, Christoph Hellwig wrote:
>> Most virtio setups have a fairly limited number of ring entries available.
>
> Seems a bit vague: QEMU at least has pretty large queues.
> Which hypervisor do you have in min
On Sun, Sep 07, 2014 at 08:47:45PM +0200, Christoph Hellwig wrote:
> On Sun, Sep 07, 2014 at 02:41:53PM +0300, Michael S. Tsirkin wrote:
> > > Signed-off-by: Christoph Hellwig
> >
> > OK so this is an optimization patch right?
> > What kind of performance gain is observed with it?
>
> None. I a
On Sun, Sep 07, 2014 at 02:41:53PM +0300, Michael S. Tsirkin wrote:
> > Signed-off-by: Christoph Hellwig
>
> OK so this is an optimization patch right?
> What kind of performance gain is observed with it?
None. I actually wrote it when the block layer had a bug when dm was
used on top of the !m
On Sat, Sep 06, 2014 at 04:09:54PM -0700, Christoph Hellwig wrote:
> Most virtio setups have a fairly limited number of ring entries available.
Seems a bit vague: QEMU at least has pretty large queues.
Which hypervisor do you have in mind?
This could be a gain everywhere if you manage to make desc
On Sun, Sep 7, 2014 at 7:09 AM, Christoph Hellwig wrote:
> Most virtio setups have a fairly limited number of ring entries available.
> Enable S/G entry merging by default to fit into less of them. This restores
> the behavior at time of the virtio-blk blk-mq conversion, which was changed
> by co
Il 07/09/2014 01:09, Christoph Hellwig ha scritto:
> Most virtio setups have a fairly limited number of ring entries available.
Are you disabling indirect descriptors? With indirect descriptors entry
merging doesn't buy you any more space, so perhaps you can key the flag
off the availability of V
Most virtio setups have a fairly limited number of ring entries available.
Enable S/G entry merging by default to fit into less of them. This restores
the behavior at time of the virtio-blk blk-mq conversion, which was changed
by commit "block: add queue flag for disabling SG merging" which made t
11 matches
Mail list logo
