Re: [PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-23 Thread Pawel Moll
On Fri, 2015-03-13 at 01:22 +, Rusty Russell wrote: > I'm sure Pawel is on a beach somewhere sipping cocktails, Ehm... There's still a some more prohibition for me (granted, by choice, just to share the "pain" ;-), so it wasn't exactly > so I'll apply > this immediately (with your updated c

Re: [PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-12 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Thu, Mar 12, 2015 at 12:33:36PM +1030, Rusty Russell wrote: >> "Michael S. Tsirkin" writes: >> > Going over the virtio mmio code, I noticed that it doesn't correctly >> > return device config values in LE format when using virtio 1.0. >> > Borrow code from virtio

Re: [PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2015 at 12:33:36PM +1030, Rusty Russell wrote: > "Michael S. Tsirkin" writes: > > Going over the virtio mmio code, I noticed that it doesn't correctly > > return device config values in LE format when using virtio 1.0. > > Borrow code from virtio_pci_modern to do this correctly. >

Re: [PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-11 Thread Rusty Russell
"Michael S. Tsirkin" writes: > Going over the virtio mmio code, I noticed that it doesn't correctly > return device config values in LE format when using virtio 1.0. > Borrow code from virtio_pci_modern to do this correctly. AFAICT, it doesn't need to. The endian correction is done by the caller

Re: [PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-09 Thread Michael S. Tsirkin
On Thu, Mar 05, 2015 at 10:54:31PM +0100, Michael S. Tsirkin wrote: > Going over the virtio mmio code, I noticed that it doesn't correctly > return device config values in LE format when using virtio 1.0. > Borrow code from virtio_pci_modern to do this correctly. > > Signed-off-by: Michael S. Tsir

[PATCH] virtio_mmio: fix endian-ness for mmio

2015-03-05 Thread Michael S. Tsirkin
Going over the virtio mmio code, I noticed that it doesn't correctly return device config values in LE format when using virtio 1.0. Borrow code from virtio_pci_modern to do this correctly. Signed-off-by: Michael S. Tsirkin --- Note: untested: QEMU doesn't support virtio 1.0 for virtio-mmio. Paw