Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread David Gould
On Thu, Feb 01, 2001 at 11:26:01AM +, Stephen C. Tweedie wrote: > On Wed, Jan 31, 2001 at 04:24:24PM -0800, David Gould wrote: > > > > I am skeptical of the argument that we can win by replacing "the least > > desirable" pages with pages were even less desireable and that we have > > no

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Rik van Riel
On Thu, 1 Feb 2001, David Gould wrote: > On Thu, Feb 01, 2001 at 11:26:01AM +, Stephen C. Tweedie wrote: > > Also remember that the readahead pages won't actually get mapped into > > memory, so they can be recycled easily. So, under swapping you tend > > to find that the extra readin pages

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Rik van Riel
On Thu, 1 Feb 2001, Ingo Oeser wrote: > On Thu, Feb 01, 2001 at 02:45:04PM -0200, Rik van Riel wrote: > > One solution could be to put (most of) the swapin readahead > > pages on the inactive_dirty list, so pressure by readahead > > on the resident pages is smaller and the not used readahead > >

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Stephen C. Tweedie
Hi, On Thu, Feb 01, 2001 at 02:45:04PM -0200, Rik van Riel wrote: > On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: > > But only when the extra pages we're reading in don't > displace useful data from memory, making us fault in > those other pages ... causing us to go to the disk > again and do

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Rik van Riel
On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: > On Thu, Feb 01, 2001 at 08:53:33AM -0200, Marcelo Tosatti wrote: > > On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: > > > > If we're under free memory shortage, "unlucky" readaheads will be harmful. > > I know, it's a balancing act. But given that

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Ingo Oeser
On Thu, Feb 01, 2001 at 02:45:04PM -0200, Rik van Riel wrote: > One solution could be to put (most of) the swapin readahead > pages on the inactive_dirty list, so pressure by readahead > on the resident pages is smaller and the not used readahead > pages are reclaimed faster. Shouldn't they be

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Stephen C. Tweedie
Hi, On Thu, Feb 01, 2001 at 08:53:33AM -0200, Marcelo Tosatti wrote: > > On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: > > If we're under free memory shortage, "unlucky" readaheads will be harmful. I know, it's a balancing act. But given that even one successful readahead per read will halve

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Marcelo Tosatti
On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: > Hi, > > On Wed, Jan 31, 2001 at 04:24:24PM -0800, David Gould wrote: > > > > I am skeptical of the argument that we can win by replacing "the least > > desirable" pages with pages were even less desireable and that we have > > no recent

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Stephen C. Tweedie
Hi, On Wed, Jan 31, 2001 at 04:24:24PM -0800, David Gould wrote: > > I am skeptical of the argument that we can win by replacing "the least > desirable" pages with pages were even less desireable and that we have > no recent indication of any need for. It seems possible under heavy swap > to

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Eric W. Biederman
David Gould <[EMAIL PROTECTED]> writes: > Hmmm, arguably reading pages we do not want is a mistake. I should think that > if a big performance win is required to justify a design choice, it should > be especially required to show such a win for doing something that on its > face is wrong. The

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Eric W. Biederman
David Gould [EMAIL PROTECTED] writes: Hmmm, arguably reading pages we do not want is a mistake. I should think that if a big performance win is required to justify a design choice, it should be especially required to show such a win for doing something that on its face is wrong. The case

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Stephen C. Tweedie
Hi, On Wed, Jan 31, 2001 at 04:24:24PM -0800, David Gould wrote: I am skeptical of the argument that we can win by replacing "the least desirable" pages with pages were even less desireable and that we have no recent indication of any need for. It seems possible under heavy swap to discard

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Marcelo Tosatti
On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: Hi, On Wed, Jan 31, 2001 at 04:24:24PM -0800, David Gould wrote: I am skeptical of the argument that we can win by replacing "the least desirable" pages with pages were even less desireable and that we have no recent indication of any

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Stephen C. Tweedie
Hi, On Thu, Feb 01, 2001 at 08:53:33AM -0200, Marcelo Tosatti wrote: On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: If we're under free memory shortage, "unlucky" readaheads will be harmful. I know, it's a balancing act. But given that even one successful readahead per read will halve the

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Ingo Oeser
On Thu, Feb 01, 2001 at 02:45:04PM -0200, Rik van Riel wrote: One solution could be to put (most of) the swapin readahead pages on the inactive_dirty list, so pressure by readahead on the resident pages is smaller and the not used readahead pages are reclaimed faster. Shouldn't they be on

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Rik van Riel
On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: On Thu, Feb 01, 2001 at 08:53:33AM -0200, Marcelo Tosatti wrote: On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: If we're under free memory shortage, "unlucky" readaheads will be harmful. I know, it's a balancing act. But given that even one

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Stephen C. Tweedie
Hi, On Thu, Feb 01, 2001 at 02:45:04PM -0200, Rik van Riel wrote: On Thu, 1 Feb 2001, Stephen C. Tweedie wrote: But only when the extra pages we're reading in don't displace useful data from memory, making us fault in those other pages ... causing us to go to the disk again and do more

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Rik van Riel
On Thu, 1 Feb 2001, Ingo Oeser wrote: On Thu, Feb 01, 2001 at 02:45:04PM -0200, Rik van Riel wrote: One solution could be to put (most of) the swapin readahead pages on the inactive_dirty list, so pressure by readahead on the resident pages is smaller and the not used readahead pages are

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread Rik van Riel
On Thu, 1 Feb 2001, David Gould wrote: On Thu, Feb 01, 2001 at 11:26:01AM +, Stephen C. Tweedie wrote: Also remember that the readahead pages won't actually get mapped into memory, so they can be recycled easily. So, under swapping you tend to find that the extra readin pages are

Re: [PATCH] vma limited swapin readahead

2001-02-01 Thread David Gould
On Thu, Feb 01, 2001 at 11:26:01AM +, Stephen C. Tweedie wrote: On Wed, Jan 31, 2001 at 04:24:24PM -0800, David Gould wrote: I am skeptical of the argument that we can win by replacing "the least desirable" pages with pages were even less desireable and that we have no recent

Re: [PATCH] vma limited swapin readahead

2001-01-31 Thread David Gould
On Wed, Jan 31, 2001 at 12:40:52PM -0700, Eric W. Biederman wrote: > Marcelo Tosatti <[EMAIL PROTECTED]> writes: > > On Wed, 31 Jan 2001, Stephen C. Tweedie wrote: > > > On Wed, Jan 31, 2001 at 01:05:02AM -0200, Marcelo Tosatti wrote: > > > > > > > > However, the pages which are contiguous on

Re: [PATCH] vma limited swapin readahead

2001-01-31 Thread Eric W. Biederman
Marcelo Tosatti <[EMAIL PROTECTED]> writes: > On Wed, 31 Jan 2001, Stephen C. Tweedie wrote: > > > Hi, > > > > On Wed, Jan 31, 2001 at 01:05:02AM -0200, Marcelo Tosatti wrote: > > > > > > However, the pages which are contiguous on swap are not necessarily > > > contiguous in the virtual

Re: [PATCH] vma limited swapin readahead

2001-01-31 Thread Marcelo Tosatti
On Wed, 31 Jan 2001, Stephen C. Tweedie wrote: > Hi, > > On Wed, Jan 31, 2001 at 01:05:02AM -0200, Marcelo Tosatti wrote: > > > > However, the pages which are contiguous on swap are not necessarily > > contiguous in the virtual memory area where the fault happened. That means > > the swapin

Re: [PATCH] vma limited swapin readahead

2001-01-31 Thread Stephen C. Tweedie
Hi, On Wed, Jan 31, 2001 at 01:05:02AM -0200, Marcelo Tosatti wrote: > > However, the pages which are contiguous on swap are not necessarily > contiguous in the virtual memory area where the fault happened. That means > the swapin readahead code may read pages which are not related to the >

Re: [PATCH] vma limited swapin readahead

2001-01-31 Thread Stephen C. Tweedie
Hi, On Wed, Jan 31, 2001 at 01:05:02AM -0200, Marcelo Tosatti wrote: However, the pages which are contiguous on swap are not necessarily contiguous in the virtual memory area where the fault happened. That means the swapin readahead code may read pages which are not related to the process

Re: [PATCH] vma limited swapin readahead

2001-01-31 Thread Marcelo Tosatti
On Wed, 31 Jan 2001, Stephen C. Tweedie wrote: Hi, On Wed, Jan 31, 2001 at 01:05:02AM -0200, Marcelo Tosatti wrote: However, the pages which are contiguous on swap are not necessarily contiguous in the virtual memory area where the fault happened. That means the swapin readahead

Re: [PATCH] vma limited swapin readahead

2001-01-31 Thread Eric W. Biederman
Marcelo Tosatti [EMAIL PROTECTED] writes: On Wed, 31 Jan 2001, Stephen C. Tweedie wrote: Hi, On Wed, Jan 31, 2001 at 01:05:02AM -0200, Marcelo Tosatti wrote: However, the pages which are contiguous on swap are not necessarily contiguous in the virtual memory area where the

Re: [PATCH] vma limited swapin readahead

2001-01-31 Thread David Gould
On Wed, Jan 31, 2001 at 12:40:52PM -0700, Eric W. Biederman wrote: Marcelo Tosatti [EMAIL PROTECTED] writes: On Wed, 31 Jan 2001, Stephen C. Tweedie wrote: On Wed, Jan 31, 2001 at 01:05:02AM -0200, Marcelo Tosatti wrote: However, the pages which are contiguous on swap are not

[PATCH] vma limited swapin readahead

2001-01-30 Thread Marcelo Tosatti
Hi, The current swapin readahead code reads a number of pages (1 >> page_cluster) which are physically contiguous on disk with reference to the page which needs to be faulted in. However, the pages which are contiguous on swap are not necessarily contiguous in the virtual memory area where

[PATCH] vma limited swapin readahead

2001-01-30 Thread Marcelo Tosatti
Hi, The current swapin readahead code reads a number of pages (1 page_cluster) which are physically contiguous on disk with reference to the page which needs to be faulted in. However, the pages which are contiguous on swap are not necessarily contiguous in the virtual memory area where the