Re: [PATCH] vmalloc: Remove alloc_map from vmap_block.

2013-02-07 Thread Johannes Weiner
On Fri, Feb 08, 2013 at 12:37:13PM +0900, Chanho Min wrote: > >I started looking for workloads to profile but then lost interest. > >The current code can theoretically end up walking through a lot of > >partially used blocks if a string of allocations never fit any of > >them. The number of these

Re: [PATCH] vmalloc: Remove alloc_map from vmap_block.

2013-02-07 Thread Chanho Min
>I started looking for workloads to profile but then lost interest. >The current code can theoretically end up walking through a lot of >partially used blocks if a string of allocations never fit any of >them. The number of these blocks depends on previous allocations that >leave them unusable

Re: [PATCH] vmalloc: Remove alloc_map from vmap_block.

2013-02-07 Thread Johannes Weiner
Hi Chanho, On Thu, Feb 07, 2013 at 11:27:54AM +0900, Chanho Min wrote: > There is no reason to maintain alloc_map in the vmap_block. > The use of alloc_map may require heavy bitmap operation sometimes. > In the worst-case, We need 1024 for-loops to find 1 free bit and > thus cause overhead.

Re: [PATCH] vmalloc: Remove alloc_map from vmap_block.

2013-02-07 Thread Chanho Min
I started looking for workloads to profile but then lost interest. The current code can theoretically end up walking through a lot of partially used blocks if a string of allocations never fit any of them. The number of these blocks depends on previous allocations that leave them unusable for

Re: [PATCH] vmalloc: Remove alloc_map from vmap_block.

2013-02-07 Thread Johannes Weiner
On Fri, Feb 08, 2013 at 12:37:13PM +0900, Chanho Min wrote: I started looking for workloads to profile but then lost interest. The current code can theoretically end up walking through a lot of partially used blocks if a string of allocations never fit any of them. The number of these blocks

Re: [PATCH] vmalloc: Remove alloc_map from vmap_block.

2013-02-07 Thread Johannes Weiner
Hi Chanho, On Thu, Feb 07, 2013 at 11:27:54AM +0900, Chanho Min wrote: There is no reason to maintain alloc_map in the vmap_block. The use of alloc_map may require heavy bitmap operation sometimes. In the worst-case, We need 1024 for-loops to find 1 free bit and thus cause overhead.

[PATCH] vmalloc: Remove alloc_map from vmap_block.

2013-02-06 Thread Chanho Min
There is no reason to maintain alloc_map in the vmap_block. The use of alloc_map may require heavy bitmap operation sometimes. In the worst-case, We need 1024 for-loops to find 1 free bit and thus cause overhead. vmap_block is fragmented unnecessarily by 2 order alignment as well. Instead we can

[PATCH] vmalloc: Remove alloc_map from vmap_block.

2013-02-06 Thread Chanho Min
There is no reason to maintain alloc_map in the vmap_block. The use of alloc_map may require heavy bitmap operation sometimes. In the worst-case, We need 1024 for-loops to find 1 free bit and thus cause overhead. vmap_block is fragmented unnecessarily by 2 order alignment as well. Instead we can