Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Martyn Welch
On Thu, 2018-09-06 at 22:04 -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case.  I think "unnecessary" is overly kind, > it does seem to be

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Martyn Welch
On Thu, 2018-09-06 at 22:04 -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case.  I think "unnecessary" is overly kind, > it does seem to be

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Greg Kroah-Hartman
On Thu, Sep 06, 2018 at 10:04:49PM -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case. I think "unnecessary" is overly kind, > it does seem

Re: [PATCH] vme: remove unneeded kfree

2018-09-07 Thread Greg Kroah-Hartman
On Thu, Sep 06, 2018 at 10:04:49PM -0700, Linus Torvalds wrote: > On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang > wrote: > > > > put_device will call vme_dev_release to free vdev, kfree is > > unnecessary here. > > That does seem to be the case. I think "unnecessary" is overly kind, > it does seem

Re: [PATCH] vme: remove unneeded kfree

2018-09-06 Thread Linus Torvalds
On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang wrote: > > put_device will call vme_dev_release to free vdev, kfree is > unnecessary here. That does seem to be the case. I think "unnecessary" is overly kind, it does seem to be a double free. Looks like the issue was introduced back in 2013 by commit

Re: [PATCH] vme: remove unneeded kfree

2018-09-06 Thread Linus Torvalds
On Thu, Sep 6, 2018 at 1:51 AM Ding Xiang wrote: > > put_device will call vme_dev_release to free vdev, kfree is > unnecessary here. That does seem to be the case. I think "unnecessary" is overly kind, it does seem to be a double free. Looks like the issue was introduced back in 2013 by commit

[PATCH] vme: remove unneeded kfree

2018-09-06 Thread Ding Xiang
put_device will call vme_dev_release to free vdev, kfree is unnecessary here. Signed-off-by: Ding Xiang --- drivers/vme/vme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 92500f6..520a5f9 100644 --- a/drivers/vme/vme.c +++ b/drivers/vme/vme.c @@

[PATCH] vme: remove unneeded kfree

2018-09-06 Thread Ding Xiang
put_device will call vme_dev_release to free vdev, kfree is unnecessary here. Signed-off-by: Ding Xiang --- drivers/vme/vme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c index 92500f6..520a5f9 100644 --- a/drivers/vme/vme.c +++ b/drivers/vme/vme.c @@