Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-28 Thread Kees Cook
On Tue, Jan 28, 2014 at 10:54 AM, Ryan Mallon wrote: > On 29/01/14 09:51, Kees Cook wrote: > >> On Mon, Jan 27, 2014 at 5:02 PM, Ryan Mallon wrote: >>> On 28/01/14 11:39, Kees Cook wrote: If arguments are consumed without output when encountering %n, it could be used to benefit or

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-28 Thread Ryan Mallon
On 29/01/14 09:51, Kees Cook wrote: > On Mon, Jan 27, 2014 at 5:02 PM, Ryan Mallon wrote: >> On 28/01/14 11:39, Kees Cook wrote: >>> If arguments are consumed without output when encountering %n, it >>> could be used to benefit or improve information leak attacks that were >>> exposed via a

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-28 Thread Kees Cook
On Mon, Jan 27, 2014 at 5:02 PM, Ryan Mallon wrote: > On 28/01/14 11:39, Kees Cook wrote: >> If arguments are consumed without output when encountering %n, it >> could be used to benefit or improve information leak attacks that were >> exposed via a limited size buffer. Since %n is not used by

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-28 Thread Kees Cook
On Mon, Jan 27, 2014 at 5:02 PM, Ryan Mallon rmal...@gmail.com wrote: On 28/01/14 11:39, Kees Cook wrote: If arguments are consumed without output when encountering %n, it could be used to benefit or improve information leak attacks that were exposed via a limited size buffer. Since %n is not

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-28 Thread Ryan Mallon
On 29/01/14 09:51, Kees Cook wrote: On Mon, Jan 27, 2014 at 5:02 PM, Ryan Mallon rmal...@gmail.com wrote: On 28/01/14 11:39, Kees Cook wrote: If arguments are consumed without output when encountering %n, it could be used to benefit or improve information leak attacks that were exposed via a

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-28 Thread Kees Cook
On Tue, Jan 28, 2014 at 10:54 AM, Ryan Mallon rmal...@gmail.com wrote: On 29/01/14 09:51, Kees Cook wrote: On Mon, Jan 27, 2014 at 5:02 PM, Ryan Mallon rmal...@gmail.com wrote: On 28/01/14 11:39, Kees Cook wrote: If arguments are consumed without output when encountering %n, it could be used

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-27 Thread Ryan Mallon
On 28/01/14 11:39, Kees Cook wrote: > If arguments are consumed without output when encountering %n, it > could be used to benefit or improve information leak attacks that were > exposed via a limited size buffer. Since %n is not used by the kernel, > there is no reason to make an info leak attack

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-27 Thread Joe Perches
On Mon, 2014-01-27 at 16:39 -0800, Kees Cook wrote: > diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] > @@ -1735,14 +1735,10 @@ int vsnprintf(char *buf, size_t size, const char > *fmt, va_list args) > case FORMAT_TYPE_NRCHARS: { > /* >*

[PATCH] vsprintf: ignore arguments to %n

2014-01-27 Thread Kees Cook
If arguments are consumed without output when encountering %n, it could be used to benefit or improve information leak attacks that were exposed via a limited size buffer. Since %n is not used by the kernel, there is no reason to make an info leak attack any easier. Signed-off-by: Kees Cook Cc:

[PATCH] vsprintf: ignore arguments to %n

2014-01-27 Thread Kees Cook
If arguments are consumed without output when encountering %n, it could be used to benefit or improve information leak attacks that were exposed via a limited size buffer. Since %n is not used by the kernel, there is no reason to make an info leak attack any easier. Signed-off-by: Kees Cook

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-27 Thread Joe Perches
On Mon, 2014-01-27 at 16:39 -0800, Kees Cook wrote: diff --git a/lib/vsprintf.c b/lib/vsprintf.c [] @@ -1735,14 +1735,10 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) case FORMAT_TYPE_NRCHARS: { /* * Since

Re: [PATCH] vsprintf: ignore arguments to %n

2014-01-27 Thread Ryan Mallon
On 28/01/14 11:39, Kees Cook wrote: If arguments are consumed without output when encountering %n, it could be used to benefit or improve information leak attacks that were exposed via a limited size buffer. Since %n is not used by the kernel, there is no reason to make an info leak attack any