Re: [PATCH] vt6656: Coding style fixes

2017-05-04 Thread Joe Perches
On Thu, 2017-05-04 at 17:33 +0200, Simo Koskinen wrote: > Fixed coding style warnings reported by checkpatch.pl. Please strive to do more than shut up checkpatch. Think a little about what this code is doing. Spend the time to analyze the code and improve it. For instance, this function is

Re: [PATCH] vt6656: Coding style fixes

2017-05-04 Thread Joe Perches
On Thu, 2017-05-04 at 17:33 +0200, Simo Koskinen wrote: > Fixed coding style warnings reported by checkpatch.pl. Please strive to do more than shut up checkpatch. Think a little about what this code is doing. Spend the time to analyze the code and improve it. For instance, this function is

[PATCH] vt6656: Coding style fixes

2017-05-04 Thread Simo Koskinen
Fixed coding style warnings reported by checkpatch.pl. Signed-off-by: Simo Koskinen --- drivers/staging/vt6656/rxtx.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index

[PATCH] vt6656: Coding style fixes

2017-05-04 Thread Simo Koskinen
Fixed coding style warnings reported by checkpatch.pl. Signed-off-by: Simo Koskinen --- drivers/staging/vt6656/rxtx.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c index 6341349..2609c1e 100644