Re: [PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-12 Thread Nick Desaulniers
On Fri, Jul 12, 2019 at 12:45 AM Arnd Bergmann wrote: > > On Fri, Jul 12, 2019 at 2:49 AM Andrew Morton > wrote: > > On Wed, 3 Jul 2019 10:10:55 +0200 Arnd Bergmann wrote: > > > > > > > Surely clang is being extraordinarily dumb here? > > > > DECLARE_WAIT_QUEUE_HEAD_ONSTACK() is effectively d

Re: [PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-12 Thread Arnd Bergmann
On Fri, Jul 12, 2019 at 9:54 AM Nathan Chancellor wrote: > > On Fri, Jul 12, 2019 at 09:45:06AM +0200, Arnd Bergmann wrote: > > On Fri, Jul 12, 2019 at 2:49 AM Andrew Morton > > wrote: > > > On Wed, 3 Jul 2019 10:10:55 +0200 Arnd Bergmann wrote: > > > > > > > > > > > Surely clang is being ext

Re: [PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-12 Thread Nathan Chancellor
On Fri, Jul 12, 2019 at 09:45:06AM +0200, Arnd Bergmann wrote: > On Fri, Jul 12, 2019 at 2:49 AM Andrew Morton > wrote: > > On Wed, 3 Jul 2019 10:10:55 +0200 Arnd Bergmann wrote: > > > > > > > Surely clang is being extraordinarily dumb here? > > > > DECLARE_WAIT_QUEUE_HEAD_ONSTACK() is effect

Re: [PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-12 Thread Arnd Bergmann
On Fri, Jul 12, 2019 at 2:49 AM Andrew Morton wrote: > On Wed, 3 Jul 2019 10:10:55 +0200 Arnd Bergmann wrote: > > > Surely clang is being extraordinarily dumb here? > > DECLARE_WAIT_QUEUE_HEAD_ONSTACK() is effectively doing > > struct wait_queue_head name = ({ __init_waitqueue_head(&na

Re: [PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-12 Thread Peter Zijlstra
On Tue, Jul 09, 2019 at 09:27:17PM +0200, Arnd Bergmann wrote: > On Wed, Jul 3, 2019 at 7:58 PM Nathan Chancellor > wrote: > > On Wed, Jul 03, 2019 at 10:10:55AM +0200, Arnd Bergmann wrote: > > > When CONFIG_LOCKDEP is set, every use of DECLARE_WAIT_QUEUE_HEAD_ONSTACK() > > > produces an annoying

Re: [PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-11 Thread Andrew Morton
On Wed, 3 Jul 2019 10:10:55 +0200 Arnd Bergmann wrote: > When CONFIG_LOCKDEP is set, every use of DECLARE_WAIT_QUEUE_HEAD_ONSTACK() > produces an annoying warning from clang, which is particularly annoying > for allmodconfig builds: > > fs/namei.c:1646:34: error: variable 'wq' is uninitialized

Re: [PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-09 Thread Arnd Bergmann
On Wed, Jul 3, 2019 at 7:58 PM Nathan Chancellor wrote: > On Wed, Jul 03, 2019 at 10:10:55AM +0200, Arnd Bergmann wrote: > > When CONFIG_LOCKDEP is set, every use of DECLARE_WAIT_QUEUE_HEAD_ONSTACK() > > produces an annoying warning from clang, which is particularly annoying > > for allmodconfig b

Re: [PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-03 Thread Nathan Chancellor
On Wed, Jul 03, 2019 at 10:10:55AM +0200, Arnd Bergmann wrote: > When CONFIG_LOCKDEP is set, every use of DECLARE_WAIT_QUEUE_HEAD_ONSTACK() > produces an annoying warning from clang, which is particularly annoying > for allmodconfig builds: > > fs/namei.c:1646:34: error: variable 'wq' is uninitial

[PATCH] waitqueue: fix clang -Wuninitialized warnings

2019-07-03 Thread Arnd Bergmann
When CONFIG_LOCKDEP is set, every use of DECLARE_WAIT_QUEUE_HEAD_ONSTACK() produces an annoying warning from clang, which is particularly annoying for allmodconfig builds: fs/namei.c:1646:34: error: variable 'wq' is uninitialized when used within its own initialization [-Werror,-Wuninitialized]