Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Wim Van Sebroeck
Hi Guenter, > On 05/14/2016 10:07 AM, Guenter Roeck wrote: > >Hi Wim, > > > >On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote: > >>Hi Guenter, > >> > >>>lockdep reports the following circular locking dependency. > >>> > > > >You are faster than me this time. I was just about to send you a pull >

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Wim Van Sebroeck
Hi Guenter, > On 05/14/2016 10:07 AM, Guenter Roeck wrote: > >Hi Wim, > > > >On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote: > >>Hi Guenter, > >> > >>>lockdep reports the following circular locking dependency. > >>> > > > >You are faster than me this time. I was just about to send you a pull >

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Guenter Roeck
On 05/14/2016 10:07 AM, Guenter Roeck wrote: Hi Wim, On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote: Hi Guenter, lockdep reports the following circular locking dependency. You are faster than me this time. I was just about to send you a pull request. Sorry for being late. The

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Guenter Roeck
On 05/14/2016 10:07 AM, Guenter Roeck wrote: Hi Wim, On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote: Hi Guenter, lockdep reports the following circular locking dependency. You are faster than me this time. I was just about to send you a pull request. Sorry for being late. The

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Guenter Roeck
Hi Wim, On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote: Hi Guenter, lockdep reports the following circular locking dependency. You are faster than me this time. I was just about to send you a pull request. Sorry for being late. The watchdog-next branch in my repository on kernel.org has

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Guenter Roeck
Hi Wim, On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote: Hi Guenter, lockdep reports the following circular locking dependency. You are faster than me this time. I was just about to send you a pull request. Sorry for being late. The watchdog-next branch in my repository on kernel.org has

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Wim Van Sebroeck
Hi Guenter, > lockdep reports the following circular locking dependency. > > == > INFO: possible circular locking dependency detected ] > 4.6.0-rc3-00191-gfabf418 #162 Not tainted > --- >

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Wim Van Sebroeck
Hi Guenter, > lockdep reports the following circular locking dependency. > > == > INFO: possible circular locking dependency detected ] > 4.6.0-rc3-00191-gfabf418 #162 Not tainted > --- >

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-09 Thread Guenter Roeck
On 05/09/2016 06:53 AM, Clemens Gruber wrote: On Thu, Apr 21, 2016 at 07:38:14AM -0700, Guenter Roeck wrote: lockdep reports the following circular locking dependency. == INFO: possible circular locking dependency detected ]

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-09 Thread Guenter Roeck
On 05/09/2016 06:53 AM, Clemens Gruber wrote: On Thu, Apr 21, 2016 at 07:38:14AM -0700, Guenter Roeck wrote: lockdep reports the following circular locking dependency. == INFO: possible circular locking dependency detected ]

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-09 Thread Clemens Gruber
On Thu, Apr 21, 2016 at 07:38:14AM -0700, Guenter Roeck wrote: > lockdep reports the following circular locking dependency. > > == > INFO: possible circular locking dependency detected ] > 4.6.0-rc3-00191-gfabf418 #162 Not tainted >

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-09 Thread Clemens Gruber
On Thu, Apr 21, 2016 at 07:38:14AM -0700, Guenter Roeck wrote: > lockdep reports the following circular locking dependency. > > == > INFO: possible circular locking dependency detected ] > 4.6.0-rc3-00191-gfabf418 #162 Not tainted >

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-04-21 Thread Guenter Roeck
On Thu, Apr 21, 2016 at 03:50:55PM +0100, One Thousand Gnomes wrote: > > Turns out the call to cancel_delayed_work_sync() in watchdog_release() > > is not necessary and can be dropped. If the worker is no longer necessary, > > the subsequent call to watchdog_update_worker() will cancel it. If it

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-04-21 Thread Guenter Roeck
On Thu, Apr 21, 2016 at 03:50:55PM +0100, One Thousand Gnomes wrote: > > Turns out the call to cancel_delayed_work_sync() in watchdog_release() > > is not necessary and can be dropped. If the worker is no longer necessary, > > the subsequent call to watchdog_update_worker() will cancel it. If it

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-04-21 Thread One Thousand Gnomes
> Turns out the call to cancel_delayed_work_sync() in watchdog_release() > is not necessary and can be dropped. If the worker is no longer necessary, > the subsequent call to watchdog_update_worker() will cancel it. If it is > already running, it won't do anything, since the worker function checks

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-04-21 Thread One Thousand Gnomes
> Turns out the call to cancel_delayed_work_sync() in watchdog_release() > is not necessary and can be dropped. If the worker is no longer necessary, > the subsequent call to watchdog_update_worker() will cancel it. If it is > already running, it won't do anything, since the worker function checks

[PATCH] watchdog: core: Fix circular locking dependency

2016-04-21 Thread Guenter Roeck
lockdep reports the following circular locking dependency. == INFO: possible circular locking dependency detected ] 4.6.0-rc3-00191-gfabf418 #162 Not tainted --- systemd/1 is trying to acquire

[PATCH] watchdog: core: Fix circular locking dependency

2016-04-21 Thread Guenter Roeck
lockdep reports the following circular locking dependency. == INFO: possible circular locking dependency detected ] 4.6.0-rc3-00191-gfabf418 #162 Not tainted --- systemd/1 is trying to acquire