Re: [PATCH] watchdog: core: suppress "watchdog did not stop" message

2018-11-26 Thread Tao Ren
On 11/26/18, 5:31 PM, "Jerry Hoemann" wrote: > Tao, > > If you're on a system running systemd, the default behavior is to > enable the watchdog during shutdown. This guards against shutdown hanging. > So this message will be routinely printed out during orderly shutdown. Thank you Jerry for the

Re: [PATCH] watchdog: core: suppress "watchdog did not stop" message

2018-11-26 Thread Jerry Hoemann
On Fri, Nov 16, 2018 at 12:37:28AM +, Tao Ren wrote: > On 11/15/18 4:19 PM, Guenter Roeck wrote: > > NACK. This message is displayed if/when the watchdog application > > exits without stopping the watchdog and/or without closing properly. > > This _is_ critical since it will reboot the system a

Re: [PATCH] watchdog: core: suppress "watchdog did not stop" message

2018-11-15 Thread Tao Ren
On 11/15/18 4:19 PM, Guenter Roeck wrote: > NACK. This message is displayed if/when the watchdog application > exits without stopping the watchdog and/or without closing properly. > This _is_ critical since it will reboot the system after the next > timeout period. > > If userspace triggers this m

Re: [PATCH] watchdog: core: suppress "watchdog did not stop" message

2018-11-15 Thread Guenter Roeck
On Thu, Nov 15, 2018 at 11:44:26PM +, Tao Ren wrote: > Currently "watchdog did not stop!" message is printed when the watchdog > timer is not stopped at close. For example, people may see the message > when rebooting the system, or the message will be logged to console > periodically if watchdo

[PATCH] watchdog: core: suppress "watchdog did not stop" message

2018-11-15 Thread Tao Ren
Currently "watchdog did not stop!" message is printed when the watchdog timer is not stopped at close. For example, people may see the message when rebooting the system, or the message will be logged to console periodically if watchdog is kicked by a scirpt which runs "echo k > /dev/watchdog" comma