Re: [PATCH] watchdog: pc87413: Rewriting of pc87413_wdt driver to use watchdog subsystem

2019-07-31 Thread Guenter Roeck
On 7/30/19 10:06 PM, Mark Balantzyan wrote: Hi all, Guenter, Thank you for your email. Unfortunately, on my end, the indentation is straight and perhaps through protocol transfer there was stray modification. checkpatch --strict says: total: 13 errors, 13 warnings, 4 checks, 439 lines checke

Re: [PATCH] watchdog: pc87413: Rewriting of pc87413_wdt driver to use watchdog subsystem

2019-07-30 Thread Mark Balantzyan
Hi all, Guenter, Thank you for your email. Unfortunately, on my end, the indentation is straight and perhaps through protocol transfer there was stray modification. I've made the other changes as indicated that I'll submit in a v2 patch shortly. Is 'v2' permissible to include in the title in th

Re: [PATCH] watchdog: pc87413: Rewriting of pc87413_wdt driver to use watchdog subsystem

2019-07-30 Thread Guenter Roeck
On 7/30/19 8:22 PM, Mark Balantzyan wrote: This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In doing so, it also addresses a potential race condition owing from the swc_base_addr variable being used before being set. Signed-off-by: Mark Balantzyan --- drivers/watchdo

[PATCH] watchdog: pc87413: Rewriting of pc87413_wdt driver to use watchdog subsystem

2019-07-30 Thread Mark Balantzyan
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In doing so, it also addresses a potential race condition owing from the swc_base_addr variable being used before being set. Signed-off-by: Mark Balantzyan --- drivers/watchdog/Kconfig | 1 + drivers/watchdog/pc87