Re: [PATCH] wbsd update

2005-03-31 Thread Pierre Ossman
Russell King wrote: >Please use platform_device_register_simple() instead of providing a buggy >release function. > > > >You might like to consider using mmc->dev instead of duplicating it >here. > > > Sorry about the delay. It's been a rather busy week. Included is the same patch with the

Re: [PATCH] wbsd update

2005-03-31 Thread Pierre Ossman
Russell King wrote: Please use platform_device_register_simple() instead of providing a buggy release function. You might like to consider using mmc-dev instead of duplicating it here. Sorry about the delay. It's been a rather busy week. Included is the same patch with the two issues

Re: [PATCH] wbsd update

2005-03-24 Thread Russell King
On Tue, Mar 22, 2005 at 10:29:35PM +0100, Pierre Ossman wrote: > @@ -1581,7 +1895,7 @@ > #define wbsd_resume NULL > #endif > > -static void wbsd_release(struct device *dev) > +static void wbsd_release_dev(struct device *dev) > { > } > > @@ -1589,7 +1903,7 @@ > .name =

Re: [PATCH] wbsd update

2005-03-24 Thread Russell King
On Tue, Mar 22, 2005 at 10:29:35PM +0100, Pierre Ossman wrote: @@ -1581,7 +1895,7 @@ #define wbsd_resume NULL #endif -static void wbsd_release(struct device *dev) +static void wbsd_release_dev(struct device *dev) { } @@ -1589,7 +1903,7 @@ .name = DRIVER_NAME,

[PATCH] wbsd update

2005-03-22 Thread Pierre Ossman
Updates to the wbsd driver. * Fix to handle DAT3 card detection. * Fixed bug which could cause large writes to stall in FIFO mode. * Plug 'n Play support. In most cases you need ACPI PNP for this to work. * Uses generic DMA API (ISA dependency removed). Index: linux/drivers/mmc/wbsd.c

Re: [PATCH] wbsd update

2005-01-21 Thread Russell King
On Wed, Jan 19, 2005 at 11:41:03AM +0100, Pierre Ossman wrote: > This patch includes the latest changes to the wbsd driver. Thanks, I've applied this patch. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA -

Re: [PATCH] wbsd update

2005-01-21 Thread Russell King
On Wed, Jan 19, 2005 at 11:41:03AM +0100, Pierre Ossman wrote: This patch includes the latest changes to the wbsd driver. Thanks, I've applied this patch. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA -

[PATCH] wbsd update

2005-01-19 Thread Pierre Ossman
This patch includes the latest changes to the wbsd driver. Changelog: * Proper usage of kunmap. * Comment about hw bugs. * Waits for data transfers to finish properly. * Added module version info. * FIFO bug fix for small reads. * Optimised FIFO loop. * DMA demand mode. * IRQ race condition when

[PATCH] wbsd update

2005-01-19 Thread Pierre Ossman
This patch includes the latest changes to the wbsd driver. Changelog: * Proper usage of kunmap. * Comment about hw bugs. * Waits for data transfers to finish properly. * Added module version info. * FIFO bug fix for small reads. * Optimised FIFO loop. * DMA demand mode. * IRQ race condition when