Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-07 Thread Kalle Valo
Joe Perches writes: >> have a >> second round of convincing ath guys to change printing code. How does >> that sound? > > Luis? Kalle? Other Qualcomm/Atheros folk? I didn't quite get what you are asking from me. But for me most important is that the current debugging facilities from user's poi

Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-07 Thread Joe Perches
On Thu, 2013-11-07 at 07:32 +, Eugene Krasnikov wrote: > Hi Joe, Hi Eugene. > I personally like the idea of making some kind of framework on top of > printing because all ath drivers are using the same printing approach > and combining all that code in one place will reduce amount of code in

Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-06 Thread Eugene Krasnikov
Hi Joe, I personally like the idea of making some kind of framework on top of printing because all ath drivers are using the same printing approach and combining all that code in one place will reduce amount of code in each particular driver. As a true engineer i like when it's less code = less wo

Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-06 Thread Joe Perches
On Wed, 2013-11-06 at 07:49 +, Eugene Krasnikov wrote: > Hm... when it comes to semicolon the patch seems to be good. When it > comes to dynamic debugging i think we should have a separate > discussion about that. > I personally like the whole idea about dynamic debug but if you want > to chang

Re: [PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-05 Thread Eugene Krasnikov
Hm... when it comes to semicolon the patch seems to be good. When it comes to dynamic debugging i think we should have a separate discussion about that. I personally like the whole idea about dynamic debug but if you want to change it i would suggest to have some kind of framework for all ath drive

[PATCH] wcn36xx: Fix logging macro with unnecessary semicolon

2013-11-05 Thread Joe Perches
The wcn36xx_err macro should not end in a semicolon as there are 2 consecutive semicolons in the preprocessed output. Remove it. Neaten the logging macros to use a more common style. Convert to use pr_debug to enable dynamic debug. Signed-off-by: Joe Perches --- drivers/net/wireless/ath/wcn36x