Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-12 Thread Arnd Bergmann
On Thursday, January 12, 2017 10:16:00 AM CET Johannes Berg wrote: > And I realized only now that this was a different place ... Right, it was a few hundred randconfigs later after I had confirmed that the first patch fixed all the configurations that were broken at first. > I've just added the c

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-12 Thread Johannes Berg
On Wed, 2017-01-11 at 21:39 +0100, Arnd Bergmann wrote: > On Wednesday, January 11, 2017 4:06:17 PM CET Johannes Berg wrote: > > > > Applied. Also fixed the typo in the subject :) > > Thanks! Unfortunately I now got another warning for the same > function, and though I would have expected the pat

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-12 Thread Johannes Berg
> Come to think of it, I'm thinking I should drop this patch and the > driver should just use iwe_stream_add_event() instead? It'll be > somewhat tricky to get the length correct though. No, turns out that's basically impossible with all the compat etc. stuff here. johannes

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-12 Thread Johannes Berg
On Wed, 2017-01-11 at 21:39 +0100, Arnd Bergmann wrote: > On Wednesday, January 11, 2017 4:06:17 PM CET Johannes Berg wrote: > > > > Applied. Also fixed the typo in the subject :) > > Thanks! Unfortunately I now got another warning for the same > function, and though I would have expected the pat

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-11 Thread Arnd Bergmann
On Wednesday, January 11, 2017 4:06:17 PM CET Johannes Berg wrote: > > Applied. Also fixed the typo in the subject :) Thanks! Unfortunately I now got another warning for the same function, and though I would have expected the patch to fix it, that did not work: In file included from /git/arm-so

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-11 Thread Johannes Berg
On Wed, 2017-01-11 at 16:00 +0100, Arnd Bergmann wrote: > On Wed, Jan 11, 2017 at 3:38 PM, Johannes Berg > wrote: > > On Wed, 2017-01-11 at 15:35 +0100, Arnd Bergmann wrote: > > > This works fine here because iwe->u.data.length is guaranteed to > > > be > > > NULL, and the memcpy doesn't actually

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-11 Thread Arnd Bergmann
On Wed, Jan 11, 2017 at 3:38 PM, Johannes Berg wrote: > On Wed, 2017-01-11 at 15:35 +0100, Arnd Bergmann wrote: >> This works fine here because iwe->u.data.length is guaranteed to be >> NULL, and the memcpy doesn't actually have an effect. > > I think you mean 0, not NULL, but I can fix that when

Re: [PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-11 Thread Johannes Berg
On Wed, 2017-01-11 at 15:35 +0100, Arnd Bergmann wrote: > gcc-7 complains that wl3501_cs passes NULL into a function that > then uses the argument as the input for memcpy: > > drivers/net/wireless/wl3501_cs.c: In function 'wl3501_get_scan': > include/net/iw_handler.h:559:3: error: argument 2 null

[PATCH] wext: handle NULL exta data in iwe_stream_add_point better

2017-01-11 Thread Arnd Bergmann
gcc-7 complains that wl3501_cs passes NULL into a function that then uses the argument as the input for memcpy: drivers/net/wireless/wl3501_cs.c: In function 'wl3501_get_scan': include/net/iw_handler.h:559:3: error: argument 2 null where non-null expected [-Werror=nonnull] memcpy(stream + poin