On Mon, 7 Mar 2005, Jörn Engel wrote:
> On Mon, 7 March 2005 03:28:46 -0700, Andreas Dilger wrote:
> >
> > Ironically, the whitespace patch gets the small things right, but misses
> > on the big readability issues, such as cifs_open() being 220 lines long
> > and having a _really_ hard time stayi
On Mon, 7 Mar 2005, Andreas Dilger wrote:
> On Mar 07, 2005 10:26 +0100, Edgar, Bob wrote:
> > I lurk on the list and didn't comment last time but there is one aspect
> > of this patch that I think is "bad" style. The function declaration should
> > not be on the same line with the type. Why? Try
On Mon, 7 March 2005 03:28:46 -0700, Andreas Dilger wrote:
>
> Ironically, the whitespace patch gets the small things right, but misses
> on the big readability issues, such as cifs_open() being 220 lines long
> and having a _really_ hard time staying inside 80 columns because of so
> many levels
20:24
> To: Steve French
> Cc: Jörn Engel; Luca Tettamanti; samba-technical; Linux Kernel Mailing
> List; Domen Puncer
> Subject: [PATCH] whitespace cleanups for fs/cifs/file.c
...
> -int
> -cifs_open(struct inode *inode, struct file *file)
> +int cifs_open(struct inode *inode,
On Mon, 7 March 2005 10:26:40 +0100, Edgar, Bob wrote:
>
> I lurk on the list and didn't comment last time but there is one aspect
> of this patch that I think is "bad" style. The function declaration should
> not be on the same line with the type. Why? Try to find the file where a
> function is d
On Mar 07, 2005 10:26 +0100, Edgar, Bob wrote:
> I lurk on the list and didn't comment last time but there is one aspect
> of this patch that I think is "bad" style. The function declaration should
> not be on the same line with the type. Why? Try to find the file where a
> function is defined ins
I would guess that Steve is at Connectathon... Might be a while before he
has time to catch up on these threads.
Chris -)-
--
"Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X
Samba Team -- http://www.samba.org/ -)- Christopher R. Hertel
jCIFS Team -- http://j
On Fri, 4 Mar 2005, Christopher R. Hertel wrote:
> I would guess that Steve is at Connectathon... Might be a while before he
> has time to catch up on these threads.
>
Ok, thank you for the info. I'll just sit back and be patient and if
nothing happens I'll pick it back up once 2.6.12 hits the
8 matches
Mail list logo