Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-07-24 Thread Kalle Valo
Eugeniu Rosca wrote: > The wl1837mod datasheet [1] says about the WL_IRQ pin: > > ---8<--- > SDIO available, interrupt out. Active high. [..] > Set to rising edge (active high) on powerup. > ---8<--- > > That's the reason of seeing the interrupt configured as: > - IRQ_TYPE_EDGE_RISING on

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-13 Thread Harish Jenny K N
On 12/06/19 8:36 PM, Eugeniu Rosca wrote: > Hi Marc, > > Thanks for your comment. > > On Wed, Jun 12, 2019 at 11:17:10AM +0100, Marc Zyngier wrote: >> Eugeniu Rosca wrote: >>> On Tue, Jun 11, 2019 at 10:00:41AM +0100, Marc Zyngier wrote: > [..] We already have plenty of that in the tree,

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-12 Thread Eugeniu Rosca
Hi Marc, Thanks for your comment. On Wed, Jun 12, 2019 at 11:17:10AM +0100, Marc Zyngier wrote: > Eugeniu Rosca wrote: > > On Tue, Jun 11, 2019 at 10:00:41AM +0100, Marc Zyngier wrote: [..] > > > We already have plenty of that in the tree, the canonical example > > > probably being

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-12 Thread Eugeniu Rosca
Hi, cc: Linus Walleij On Tue, Jun 11, 2019 at 10:00:41AM +0100, Marc Zyngier wrote: > On 11/06/2019 09:45, Geert Uytterhoeven wrote: > > CC irqchip > > > > Original thread at > > https://lore.kernel.org/lkml/20190607172958.20745-1-ero...@de.adit-jv.com/ > > > > On Mon, Jun 10, 2019 at 10:30 AM

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-11 Thread Marc Zyngier
On 11/06/2019 09:45, Geert Uytterhoeven wrote: > CC irqchip > > Original thread at > https://lore.kernel.org/lkml/20190607172958.20745-1-ero...@de.adit-jv.com/ > > On Mon, Jun 10, 2019 at 10:30 AM Tony Lindgren wrote: >> * Kalle Valo [190610 07:01]: >>> Eugeniu Rosca writes: >>> The

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-11 Thread Geert Uytterhoeven
CC irqchip Original thread at https://lore.kernel.org/lkml/20190607172958.20745-1-ero...@de.adit-jv.com/ On Mon, Jun 10, 2019 at 10:30 AM Tony Lindgren wrote: > * Kalle Valo [190610 07:01]: > > Eugeniu Rosca writes: > > > > > The wl1837mod datasheet [1] says about the WL_IRQ pin: > > > > > >

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-10 Thread Tony Lindgren
Hi, * Kalle Valo [190610 07:01]: > Eugeniu Rosca writes: > > > The wl1837mod datasheet [1] says about the WL_IRQ pin: > > > > ---8<--- > > SDIO available, interrupt out. Active high. [..] > > Set to rising edge (active high) on powerup. > > ---8<--- > > > > That's the reason of seeing the

Re: [PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-10 Thread Kalle Valo
Eugeniu Rosca writes: > The wl1837mod datasheet [1] says about the WL_IRQ pin: > > ---8<--- > SDIO available, interrupt out. Active high. [..] > Set to rising edge (active high) on powerup. > ---8<--- > > That's the reason of seeing the interrupt configured as: > - IRQ_TYPE_EDGE_RISING on

[PATCH] wlcore/wl18xx: Add invert-irq OF property for physically inverted IRQ

2019-06-07 Thread Eugeniu Rosca
The wl1837mod datasheet [1] says about the WL_IRQ pin: ---8<--- SDIO available, interrupt out. Active high. [..] Set to rising edge (active high) on powerup. ---8<--- That's the reason of seeing the interrupt configured as: - IRQ_TYPE_EDGE_RISING on HiKey 960/970 - IRQ_TYPE_LEVEL_HIGH on a