Re: [PATCH] workqueue: Guarantee work function memory ordering

2014-02-22 Thread Tejun Heo
Hello, Peter. On Sat, Feb 22, 2014 at 10:05:53AM -0500, Peter Hurley wrote: > Given your concerns about the performance impact, maybe we should > ask Fengguang to run this change through his automated test suites > to find out what the perf delta is? It should be fine. It's more like I just didn

Re: [PATCH] workqueue: Guarantee work function memory ordering

2014-02-22 Thread Peter Hurley
On 02/22/2014 09:40 AM, Tejun Heo wrote: On Sat, Feb 22, 2014 at 07:11:51AM -0500, Peter Hurley wrote: Users of the workqueue api may assume the workqueue provides a memory ordering guarantee for re-queued work items; ie., that if a work item is not queue-able then the previously queued work ins

Re: [PATCH] workqueue: Guarantee work function memory ordering

2014-02-22 Thread Tejun Heo
On Sat, Feb 22, 2014 at 07:11:51AM -0500, Peter Hurley wrote: > Users of the workqueue api may assume the workqueue provides a > memory ordering guarantee for re-queued work items; ie., that > if a work item is not queue-able then the previously queued > work instance is not running and so any memo

[PATCH] workqueue: Guarantee work function memory ordering

2014-02-22 Thread Peter Hurley
Users of the workqueue api may assume the workqueue provides a memory ordering guarantee for re-queued work items; ie., that if a work item is not queue-able then the previously queued work instance is not running and so any memory operations which occur before queuing the work will be visible to t