Re: [PATCH] workqueue: detach rescuer from pool until the last

2014-07-18 Thread Tejun Heo
Hello, On Wed, Jul 16, 2014 at 02:56:50PM +0800, Lai Jiangshan wrote: > @@ -2300,11 +2300,6 @@ repeat: > move_linked_works(work, scheduled, ); > > process_scheduled_works(rescuer); > - spin_unlock_irq(>lock); > - > -

Re: [PATCH] workqueue: detach rescuer from pool until the last

2014-07-18 Thread Tejun Heo
Hello, On Wed, Jul 16, 2014 at 02:56:50PM +0800, Lai Jiangshan wrote: @@ -2300,11 +2300,6 @@ repeat: move_linked_works(work, scheduled, n); process_scheduled_works(rescuer); - spin_unlock_irq(pool-lock); - -

[PATCH] workqueue: detach rescuer from pool until the last

2014-07-16 Thread Lai Jiangshan
In 51697d393922 ("workqueue: use generic attach/detach routine for rescuers"), The rescuer detaches itself from the pool before put_pwq() so that the put_unbound_pool() will not destroy the rescuer-attached pool. It is unnecessary, worker_detach_from_pool() can be used as the last statement to

[PATCH] workqueue: detach rescuer from pool until the last

2014-07-16 Thread Lai Jiangshan
In 51697d393922 (workqueue: use generic attach/detach routine for rescuers), The rescuer detaches itself from the pool before put_pwq() so that the put_unbound_pool() will not destroy the rescuer-attached pool. It is unnecessary, worker_detach_from_pool() can be used as the last statement to