Re: [PATCH] workqueue: missing idr_preload_end() in worker_pool_assign_id()

2013-03-13 Thread Tejun Heo
Hello, On Wed, Mar 13, 2013 at 2:51 PM, Stephen Rothwell wrote: >> That patch doesn't use idr_preload(). It looks like the issue is >> introduced during linux-next merge of wq/for-3.10 and idr patches in >> -mm. Stephen, can you please add idr_preload_end() to the merge >> patch? > > Oops, sorr

Re: [PATCH] workqueue: missing idr_preload_end() in worker_pool_assign_id()

2013-03-13 Thread Stephen Rothwell
Hi Tejun, On Wed, 13 Mar 2013 10:57:45 -0700 Tejun Heo wrote: > > (cc'ing Stephen and linux-next) > > Hello, Artem. > > On Wed, Mar 13, 2013 at 09:51:32PM +0400, Artem Savkov wrote: > > Added missing idr_preload_end() call in worker_pool_assign_id(). > > Without it preemption stays disabled res

Re: [PATCH] workqueue: missing idr_preload_end() in worker_pool_assign_id()

2013-03-13 Thread Tejun Heo
(cc'ing Stephen and linux-next) Hello, Artem. On Wed, Mar 13, 2013 at 09:51:32PM +0400, Artem Savkov wrote: > Added missing idr_preload_end() call in worker_pool_assign_id(). > Without it preemption stays disabled resulting in lots of "scheduling while > atomic" BUGs during boot. ... > Introduced

[PATCH] workqueue: missing idr_preload_end() in worker_pool_assign_id()

2013-03-13 Thread Artem Savkov
Added missing idr_preload_end() call in worker_pool_assign_id(). Without it preemption stays disabled resulting in lots of "scheduling while atomic" BUGs during boot. [0.167848] BUG: scheduling while atomic: swapper/0/1/0x1009 [0.167951] no locks held by swapper/0/1. [0.168046] Mod