Re: [PATCH] workqueue: remove the confusing POOL_FREEZING

2014-05-22 Thread Tejun Heo
Hello, On Thu, May 22, 2014 at 07:01:16PM +0800, Lai Jiangshan wrote: > While freezing takes place globally, its execution is per-workqueue; > however, the current implementation makes use of the per-worker_pool > POOL_FREEZING flag. While it's not broken, the flag makes the code > more

[PATCH] workqueue: remove the confusing POOL_FREEZING

2014-05-22 Thread Lai Jiangshan
While freezing takes place globally, its execution is per-workqueue; however, the current implementation makes use of the per-worker_pool POOL_FREEZING flag. While it's not broken, the flag makes the code more confusing and complicates freeze_workqueues_begin() and thaw_workqueues() by requiring

[PATCH] workqueue: remove the confusing POOL_FREEZING

2014-05-22 Thread Lai Jiangshan
While freezing takes place globally, its execution is per-workqueue; however, the current implementation makes use of the per-worker_pool POOL_FREEZING flag. While it's not broken, the flag makes the code more confusing and complicates freeze_workqueues_begin() and thaw_workqueues() by requiring

Re: [PATCH] workqueue: remove the confusing POOL_FREEZING

2014-05-22 Thread Tejun Heo
Hello, On Thu, May 22, 2014 at 07:01:16PM +0800, Lai Jiangshan wrote: While freezing takes place globally, its execution is per-workqueue; however, the current implementation makes use of the per-worker_pool POOL_FREEZING flag. While it's not broken, the flag makes the code more confusing