Re: [PATCH] writeback: clear auto_free in initializaiton

2020-09-02 Thread Tejun Heo
Hello, On Wed, Aug 26, 2020 at 06:11:26PM +0200, Jan Kara wrote: > > Which seems like a strange place to set auto_free as > > it is not where the rest of base_work is initialized. > > Otherwise I agree it's a strange place. I've added Tejun to CC just in case > he remembers why he's added that.

Re: [PATCH] writeback: clear auto_free in initializaiton

2020-08-26 Thread Jan Kara
On Tue 18-08-20 07:13:30, t...@redhat.com wrote: > From: Tom Rix > > Review fs/fs-writeback.c bdi_split_work_to_wbs > The CONFIG_CGROUP_WRITEBACK version contains this line > base_work->auto_free = 0; It is actually the !CONFIG_CGROUP_WRITEBACK version... > Which seems like a strange plac

[PATCH] writeback: clear auto_free in initializaiton

2020-08-18 Thread trix
From: Tom Rix Review fs/fs-writeback.c bdi_split_work_to_wbs The CONFIG_CGROUP_WRITEBACK version contains this line base_work->auto_free = 0; Which seems like a strange place to set auto_free as it is not where the rest of base_work is initialized. In the default version of bdi_split_wor