Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages()

2017-10-02 Thread Johannes Weiner
On Mon, Oct 02, 2017 at 09:56:16AM +0200, Michal Hocko wrote: > On Wed 27-09-17 15:13:11, Tahsin Erdogan wrote: > > "mapping" parameter to balance_dirty_pages() is not used anymore. > > > > Fixes: dfb8ae567835 ("writeback: let balance_dirty_pages() work on the > > matching cgroup bdi_writeback")

Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages()

2017-10-02 Thread Michal Hocko
On Mon 02-10-17 10:20:37, Tahsin Erdogan wrote: > On Mon, Oct 2, 2017 at 12:56 AM, Michal Hocko wrote: > > balance_dirty_pages_ratelimited doesn't really need mapping as well. All > > it needs is the inode and we already have it in callers. So would it > > make sense to refactor a bit further and

Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages()

2017-10-02 Thread Tahsin Erdogan
On Mon, Oct 2, 2017 at 12:56 AM, Michal Hocko wrote: > balance_dirty_pages_ratelimited doesn't really need mapping as well. All > it needs is the inode and we already have it in callers. So would it > make sense to refactor a bit further and make its argument an inode? My only concern is that, ba

Re: [PATCH] writeback: remove unused parameter from balance_dirty_pages()

2017-10-02 Thread Michal Hocko
On Wed 27-09-17 15:13:11, Tahsin Erdogan wrote: > "mapping" parameter to balance_dirty_pages() is not used anymore. > > Fixes: dfb8ae567835 ("writeback: let balance_dirty_pages() work on the > matching cgroup bdi_writeback") balance_dirty_pages_ratelimited doesn't really need mapping as well. Al

[PATCH] writeback: remove unused parameter from balance_dirty_pages()

2017-09-27 Thread Tahsin Erdogan
"mapping" parameter to balance_dirty_pages() is not used anymore. Fixes: dfb8ae567835 ("writeback: let balance_dirty_pages() work on the matching cgroup bdi_writeback") Signed-off-by: Tahsin Erdogan --- mm/page-writeback.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git