Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v3]

2014-01-05 Thread rui wang
On 1/6/14, Prarit Bhargava wrote: > I tested this by doing a continuous loop of booting a system, downing all > cpus, and then rebooting. Before every reboot I grepped the dmesg log for > the do_IRQ warning to see if there were any additional do_IRQ warnings and > I do not see any after applying

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v3]

2014-01-05 Thread Prarit Bhargava
I tested this by doing a continuous loop of booting a system, downing all cpus, and then rebooting. Before every reboot I grepped the dmesg log for the do_IRQ warning to see if there were any additional do_IRQ warnings and I do not see any after applying this patch. I also tested on several

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2014-01-05 Thread Prarit Bhargava
On 01/05/2014 11:07 AM, Prarit Bhargava wrote: > I tested this by doing a continuous loop of booting a system, downing all > cpus, and then rebooting. Before every reboot I grepped the dmesg log for > the do_IRQ warning to see if there were any additional do_IRQ warnings and > I do not see any

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2014-01-05 Thread Prarit Bhargava
I tested this by doing a continuous loop of booting a system, downing all cpus, and then rebooting. Before every reboot I grepped the dmesg log for the do_IRQ warning to see if there were any additional do_IRQ warnings and I do not see any after applying this patch. I also tested on several

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2014-01-05 Thread Prarit Bhargava
On 01/05/2014 11:07 AM, Prarit Bhargava wrote: I tested this by doing a continuous loop of booting a system, downing all cpus, and then rebooting. Before every reboot I grepped the dmesg log for the do_IRQ warning to see if there were any additional do_IRQ warnings and I do not see any

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2014-01-05 Thread Prarit Bhargava
I tested this by doing a continuous loop of booting a system, downing all cpus, and then rebooting. Before every reboot I grepped the dmesg log for the do_IRQ warning to see if there were any additional do_IRQ warnings and I do not see any after applying this patch. I also tested on several

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v3]

2014-01-05 Thread Prarit Bhargava
I tested this by doing a continuous loop of booting a system, downing all cpus, and then rebooting. Before every reboot I grepped the dmesg log for the do_IRQ warning to see if there were any additional do_IRQ warnings and I do not see any after applying this patch. I also tested on several

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v3]

2014-01-05 Thread rui wang
On 1/6/14, Prarit Bhargava pra...@redhat.com wrote: I tested this by doing a continuous loop of booting a system, downing all cpus, and then rebooting. Before every reboot I grepped the dmesg log for the do_IRQ warning to see if there were any additional do_IRQ warnings and I do not see any

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2014-01-03 Thread rui wang
On 12/29/13, Prarit Bhargava wrote: > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 > > When downing a cpu it is possible that there are unhandled irqs left in > the APIC IRR register. The following code path shows how the problem > can occur: > > 1. CPU 5 is to go down. > 2. CPU 5

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2014-01-03 Thread rui wang
On 12/29/13, Prarit Bhargava pra...@redhat.com wrote: Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. The following code path shows how the problem can occur: 1. CPU 5 is to go down.

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2013-12-28 Thread Prarit Bhargava
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. The following code path shows how the problem can occur: 1. CPU 5 is to go down. 2. CPU 5 IRQ 12 IRR is set to request service, but ISR is

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs [v2]

2013-12-28 Thread Prarit Bhargava
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. The following code path shows how the problem can occur: 1. CPU 5 is to go down. 2. CPU 5 IRQ 12 IRR is set to request service, but ISR is

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-27 Thread Prarit Bhargava
On 12/25/2013 03:22 AM, rui wang wrote: > > Yes that comment was what triggered me to think that the issue wasn't > understood. You now have a clear enough explanation. > Rui, you've pointed out that my patch description in insufficient. I'll rewrite it and resubmit with a much more detailed

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-27 Thread Prarit Bhargava
On 12/25/2013 03:22 AM, rui wang wrote: Yes that comment was what triggered me to think that the issue wasn't understood. You now have a clear enough explanation. Rui, you've pointed out that my patch description in insufficient. I'll rewrite it and resubmit with a much more detailed

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-25 Thread rui wang
On 12/24/13, Prarit Bhargava wrote: > > > On 12/23/2013 11:41 PM, rui wang wrote: >> On 12/23/13, Prarit Bhargava wrote: >> > I think I have root caused this to the IRR being set in the down'd cpu. >> > It >> > is >> > admittedly a rare occurrence in the kernel. I usually have to run >> > about

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-25 Thread rui wang
On 12/24/13, Prarit Bhargava pra...@redhat.com wrote: On 12/23/2013 11:41 PM, rui wang wrote: On 12/23/13, Prarit Bhargava pra...@redhat.com wrote: I think I have root caused this to the IRR being set in the down'd cpu. It is admittedly a rare occurrence in the kernel. I usually have

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-24 Thread Prarit Bhargava
On 12/23/2013 11:41 PM, rui wang wrote: > On 12/23/13, Prarit Bhargava wrote: > > I think I have root caused this to the IRR being set in the down'd cpu. It > > is > > admittedly a rare occurrence in the kernel. I usually have to run about > > 1000 up > > and down's before hitting it,

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-24 Thread Prarit Bhargava
On 12/23/2013 11:41 PM, rui wang wrote: On 12/23/13, Prarit Bhargava pra...@redhat.com wrote: I think I have root caused this to the IRR being set in the down'd cpu. It is admittedly a rare occurrence in the kernel. I usually have to run about 1000 up and down's before hitting it,

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-23 Thread rui wang
On 12/23/13, Prarit Bhargava wrote: > > > On 12/23/2013 04:41 AM, rui wang wrote: >> On 12/2/13, Prarit Bhargava wrote: >>> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 >>> >>> When downing a cpu it is possible that there are unhandled irqs left in >>> the APIC IRR register.

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-23 Thread Prarit Bhargava
On 12/23/2013 04:41 AM, rui wang wrote: > On 12/2/13, Prarit Bhargava wrote: >> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 >> >> When downing a cpu it is possible that there are unhandled irqs left in >> the APIC IRR register. fixup_irqs() goes through the IRR and retriggers

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-23 Thread rui wang
On 12/2/13, Prarit Bhargava wrote: > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 > > When downing a cpu it is possible that there are unhandled irqs left in > the APIC IRR register. fixup_irqs() goes through the IRR and retriggers > the IRQs left in the APIC IRR. After this, the

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-23 Thread rui wang
On 12/2/13, Prarit Bhargava pra...@redhat.com wrote: Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. fixup_irqs() goes through the IRR and retriggers the IRQs left in the APIC IRR.

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-23 Thread Prarit Bhargava
On 12/23/2013 04:41 AM, rui wang wrote: On 12/2/13, Prarit Bhargava pra...@redhat.com wrote: Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. fixup_irqs() goes through the IRR and

Re: [PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-23 Thread rui wang
On 12/23/13, Prarit Bhargava pra...@redhat.com wrote: On 12/23/2013 04:41 AM, rui wang wrote: On 12/2/13, Prarit Bhargava pra...@redhat.com wrote: Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-02 Thread Prarit Bhargava
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. fixup_irqs() goes through the IRR and retriggers the IRQs left in the APIC IRR. After this, the vector for the irq is set to -1. There is a

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-12-02 Thread Prarit Bhargava
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. fixup_irqs() goes through the IRR and retriggers the IRQs left in the APIC IRR. After this, the vector for the irq is set to -1. There is a

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-11-19 Thread Prarit Bhargava
Second try at this Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. fixup_irqs() goes through the IRR and retriggers the IRQs left in the APIC IRR. After this, the vector for the irq

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-11-19 Thread Prarit Bhargava
Second try at this Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. fixup_irqs() goes through the IRR and retriggers the IRQs left in the APIC IRR. After this, the vector for the irq

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-11-11 Thread Prarit Bhargava
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. fixup_irqs() goes through the IRR and retriggers the IRQs left in the APIC IRR. After this, the vector for the irq is set to -1. There is a

[PATCH] x86, Fix do_IRQ interrupt warning for cpu hotplug retriggered irqs

2013-11-11 Thread Prarit Bhargava
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64831 When downing a cpu it is possible that there are unhandled irqs left in the APIC IRR register. fixup_irqs() goes through the IRR and retriggers the IRQs left in the APIC IRR. After this, the vector for the irq is set to -1. There is a