Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Josh Triplett
On Fri, Oct 31, 2014 at 01:55:33PM -0700, Kees Cook wrote: > On Fri, Oct 31, 2014 at 1:33 PM, wrote: > > On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote: > >> This is useful for reporting various addresses or other values while > >> debugging early boot. > >> > >> Signed-off-by: Kees

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Kees Cook
On Fri, Oct 31, 2014 at 1:33 PM, wrote: > On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote: >> This is useful for reporting various addresses or other values while >> debugging early boot. >> >> Signed-off-by: Kees Cook > > You haven't provided any user of this function. I don't think

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread josh
On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote: > This is useful for reporting various addresses or other values while > debugging early boot. > > Signed-off-by: Kees Cook You haven't provided any user of this function. I don't think this should get merged without a caller (nor

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread H. Peter Anvin
On 10/31/2014 01:11 PM, Vivek Goyal wrote: > On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote: +void __puthex(unsigned long value) +{ + char alpha[2] = "0"; + int bits; + unsigned char byte; >>> >>> what is 'byte' for? (unused) >> >> Well the whole function

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Vivek Goyal
On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote: > > > +void __puthex(unsigned long value) > > > +{ > > > + char alpha[2] = "0"; > > > + int bits; > > > + unsigned char byte; > > > > what is 'byte' for? (unused) > > Well the whole function is unused. We don't normally add unused

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Andi Kleen
> > +void __puthex(unsigned long value) > > +{ > > + char alpha[2] = "0"; > > + int bits; > > + unsigned char byte; > > what is 'byte' for? (unused) Well the whole function is unused. We don't normally add unused functions to the code because they bitrot too easily. If you need it please

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Randy Dunlap
On 10/31/14 09:20, Kees Cook wrote: > This is useful for reporting various addresses or other values while > debugging early boot. > > Signed-off-by: Kees Cook > --- > arch/x86/boot/compressed/misc.c | 19 +++ > arch/x86/boot/compressed/misc.h | 5 + > 2 files changed, 24

[PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Kees Cook
This is useful for reporting various addresses or other values while debugging early boot. Signed-off-by: Kees Cook --- arch/x86/boot/compressed/misc.c | 19 +++ arch/x86/boot/compressed/misc.h | 5 + 2 files changed, 24 insertions(+) diff --git

[PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Kees Cook
This is useful for reporting various addresses or other values while debugging early boot. Signed-off-by: Kees Cook keesc...@chromium.org --- arch/x86/boot/compressed/misc.c | 19 +++ arch/x86/boot/compressed/misc.h | 5 + 2 files changed, 24 insertions(+) diff --git

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Randy Dunlap
On 10/31/14 09:20, Kees Cook wrote: This is useful for reporting various addresses or other values while debugging early boot. Signed-off-by: Kees Cook keesc...@chromium.org --- arch/x86/boot/compressed/misc.c | 19 +++ arch/x86/boot/compressed/misc.h | 5 + 2 files

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Andi Kleen
+void __puthex(unsigned long value) +{ + char alpha[2] = 0; + int bits; + unsigned char byte; what is 'byte' for? (unused) Well the whole function is unused. We don't normally add unused functions to the code because they bitrot too easily. If you need it please just patch it

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Vivek Goyal
On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote: +void __puthex(unsigned long value) +{ + char alpha[2] = 0; + int bits; + unsigned char byte; what is 'byte' for? (unused) Well the whole function is unused. We don't normally add unused functions to the code

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread H. Peter Anvin
On 10/31/2014 01:11 PM, Vivek Goyal wrote: On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote: +void __puthex(unsigned long value) +{ + char alpha[2] = 0; + int bits; + unsigned char byte; what is 'byte' for? (unused) Well the whole function is unused. We don't normally add

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread josh
On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote: This is useful for reporting various addresses or other values while debugging early boot. Signed-off-by: Kees Cook keesc...@chromium.org You haven't provided any user of this function. I don't think this should get merged without a

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Kees Cook
On Fri, Oct 31, 2014 at 1:33 PM, j...@joshtriplett.org wrote: On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote: This is useful for reporting various addresses or other values while debugging early boot. Signed-off-by: Kees Cook keesc...@chromium.org You haven't provided any user

Re: [PATCH] x86, boot: add hex output for debugging

2014-10-31 Thread Josh Triplett
On Fri, Oct 31, 2014 at 01:55:33PM -0700, Kees Cook wrote: On Fri, Oct 31, 2014 at 1:33 PM, j...@joshtriplett.org wrote: On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote: This is useful for reporting various addresses or other values while debugging early boot. Signed-off-by: