On Fri, Oct 31, 2014 at 01:55:33PM -0700, Kees Cook wrote:
> On Fri, Oct 31, 2014 at 1:33 PM, wrote:
> > On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote:
> >> This is useful for reporting various addresses or other values while
> >> debugging early boot.
> >>
> >> Signed-off-by: Kees
On Fri, Oct 31, 2014 at 1:33 PM, wrote:
> On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote:
>> This is useful for reporting various addresses or other values while
>> debugging early boot.
>>
>> Signed-off-by: Kees Cook
>
> You haven't provided any user of this function. I don't think
On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote:
> This is useful for reporting various addresses or other values while
> debugging early boot.
>
> Signed-off-by: Kees Cook
You haven't provided any user of this function. I don't think this
should get merged without a caller (nor
On 10/31/2014 01:11 PM, Vivek Goyal wrote:
> On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote:
+void __puthex(unsigned long value)
+{
+ char alpha[2] = "0";
+ int bits;
+ unsigned char byte;
>>>
>>> what is 'byte' for? (unused)
>>
>> Well the whole function
On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote:
> > > +void __puthex(unsigned long value)
> > > +{
> > > + char alpha[2] = "0";
> > > + int bits;
> > > + unsigned char byte;
> >
> > what is 'byte' for? (unused)
>
> Well the whole function is unused. We don't normally add unused
> > +void __puthex(unsigned long value)
> > +{
> > + char alpha[2] = "0";
> > + int bits;
> > + unsigned char byte;
>
> what is 'byte' for? (unused)
Well the whole function is unused. We don't normally add unused functions
to the code because they bitrot too easily.
If you need it please
On 10/31/14 09:20, Kees Cook wrote:
> This is useful for reporting various addresses or other values while
> debugging early boot.
>
> Signed-off-by: Kees Cook
> ---
> arch/x86/boot/compressed/misc.c | 19 +++
> arch/x86/boot/compressed/misc.h | 5 +
> 2 files changed, 24
This is useful for reporting various addresses or other values while
debugging early boot.
Signed-off-by: Kees Cook
---
arch/x86/boot/compressed/misc.c | 19 +++
arch/x86/boot/compressed/misc.h | 5 +
2 files changed, 24 insertions(+)
diff --git
This is useful for reporting various addresses or other values while
debugging early boot.
Signed-off-by: Kees Cook keesc...@chromium.org
---
arch/x86/boot/compressed/misc.c | 19 +++
arch/x86/boot/compressed/misc.h | 5 +
2 files changed, 24 insertions(+)
diff --git
On 10/31/14 09:20, Kees Cook wrote:
This is useful for reporting various addresses or other values while
debugging early boot.
Signed-off-by: Kees Cook keesc...@chromium.org
---
arch/x86/boot/compressed/misc.c | 19 +++
arch/x86/boot/compressed/misc.h | 5 +
2 files
+void __puthex(unsigned long value)
+{
+ char alpha[2] = 0;
+ int bits;
+ unsigned char byte;
what is 'byte' for? (unused)
Well the whole function is unused. We don't normally add unused functions
to the code because they bitrot too easily.
If you need it please just patch it
On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote:
+void __puthex(unsigned long value)
+{
+ char alpha[2] = 0;
+ int bits;
+ unsigned char byte;
what is 'byte' for? (unused)
Well the whole function is unused. We don't normally add unused functions
to the code
On 10/31/2014 01:11 PM, Vivek Goyal wrote:
On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote:
+void __puthex(unsigned long value)
+{
+ char alpha[2] = 0;
+ int bits;
+ unsigned char byte;
what is 'byte' for? (unused)
Well the whole function is unused. We don't normally add
On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote:
This is useful for reporting various addresses or other values while
debugging early boot.
Signed-off-by: Kees Cook keesc...@chromium.org
You haven't provided any user of this function. I don't think this
should get merged without a
On Fri, Oct 31, 2014 at 1:33 PM, j...@joshtriplett.org wrote:
On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote:
This is useful for reporting various addresses or other values while
debugging early boot.
Signed-off-by: Kees Cook keesc...@chromium.org
You haven't provided any user
On Fri, Oct 31, 2014 at 01:55:33PM -0700, Kees Cook wrote:
On Fri, Oct 31, 2014 at 1:33 PM, j...@joshtriplett.org wrote:
On Fri, Oct 31, 2014 at 09:20:37AM -0700, Kees Cook wrote:
This is useful for reporting various addresses or other values while
debugging early boot.
Signed-off-by:
16 matches
Mail list logo