Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/27/2013 08:07 PM, H. Peter Anvin wrote: > On 12/27/2013 08:13 AM, Prarit Bhargava wrote: >>> >>> Back to my question, assume cpu1 will be off-lined and one irq affinity is >>> set as (1, 2) -- this irq will be bypassed. Looks good. But if one irq >>> affinity is set as only (1), -- this

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/27/2013 08:07 PM, H. Peter Anvin wrote: On 12/27/2013 08:13 AM, Prarit Bhargava wrote: Back to my question, assume cpu1 will be off-lined and one irq affinity is set as (1, 2) -- this irq will be bypassed. Looks good. But if one irq affinity is set as only (1), -- this irq is

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/27/2013 08:13 AM, Prarit Bhargava wrote: >> >> Back to my question, assume cpu1 will be off-lined and one irq affinity is >> set as (1, 2) -- this irq will be bypassed. Looks good. But if one irq >> affinity is set as only (1), -- this irq is bypassed, too. Not right! > > Oh, yes, this is a

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/23/2013 06:39 AM, Prarit Bhargava wrote: > Patch is against linux-tip.git and was tested on both linux.git and tip > without > any issues. As expected, the number of required vectors for the down'd cpu > drops from 202 to 181 on my test system (which has 509 vectors assigned in > total). >

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/24/2013 09:40 PM, Chen, Gong wrote: > On Tue, Dec 24, 2013 at 08:19:09AM -0500, Prarit Bhargava wrote: >> On 12/23/2013 09:51 PM, Chen, Gong wrote: >>> On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote: diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/24/2013 09:40 PM, Chen, Gong wrote: On Tue, Dec 24, 2013 at 08:19:09AM -0500, Prarit Bhargava wrote: On 12/23/2013 09:51 PM, Chen, Gong wrote: On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote: diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/23/2013 06:39 AM, Prarit Bhargava wrote: Patch is against linux-tip.git and was tested on both linux.git and tip without any issues. As expected, the number of required vectors for the down'd cpu drops from 202 to 181 on my test system (which has 509 vectors assigned in total).

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/27/2013 08:13 AM, Prarit Bhargava wrote: Back to my question, assume cpu1 will be off-lined and one irq affinity is set as (1, 2) -- this irq will be bypassed. Looks good. But if one irq affinity is set as only (1), -- this irq is bypassed, too. Not right! Oh, yes, this is a bug. ...

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On Tue, Dec 24, 2013 at 08:19:09AM -0500, Prarit Bhargava wrote: > On 12/23/2013 09:51 PM, Chen, Gong wrote: > > On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote: > >> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c > >> index 7d40698..aed7acc 100644 > >> ---

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/23/2013 09:51 PM, Chen, Gong wrote: > On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote: >> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c >> index 7d40698..aed7acc 100644 >> --- a/arch/x86/kernel/irq.c >> +++ b/arch/x86/kernel/irq.c >> @@ -281,7 +281,7 @@ int

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On 12/23/2013 09:51 PM, Chen, Gong wrote: On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote: diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 7d40698..aed7acc 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -281,7 +281,7 @@ int

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On Tue, Dec 24, 2013 at 08:19:09AM -0500, Prarit Bhargava wrote: On 12/23/2013 09:51 PM, Chen, Gong wrote: On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote: diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 7d40698..aed7acc 100644 --- a/arch/x86/kernel/irq.c

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote: > diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c > index 7d40698..aed7acc 100644 > --- a/arch/x86/kernel/irq.c > +++ b/arch/x86/kernel/irq.c > @@ -281,7 +281,7 @@ int check_irq_vectors_for_cpu_disable(void) >

[PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

Patch is against linux-tip.git and was tested on both linux.git and tip without any issues. As expected, the number of required vectors for the down'd cpu drops from 202 to 181 on my test system (which has 509 vectors assigned in total). Many thanks to Gong Chen for catching this. P.

[PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

Patch is against linux-tip.git and was tested on both linux.git and tip without any issues. As expected, the number of required vectors for the down'd cpu drops from 202 to 181 on my test system (which has 509 vectors assigned in total). Many thanks to Gong Chen for catching this. P. 8

Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote: diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 7d40698..aed7acc 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -281,7 +281,7 @@ int check_irq_vectors_for_cpu_disable(void)