Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

2012-09-24 Thread Masami Hiramatsu
(2012/09/20 18:40), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> (2012/09/20 18:25), Ingo Molnar wrote: >>> >>> * Masami Hiramatsu wrote: >>> (2012/09/19 22:46), Borislav Petkov wrote: > From: Borislav Petkov > > I get > > arch/x86/kernel/kprobes.c:544:23: war

Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

2012-09-20 Thread Ingo Molnar
* Borislav Petkov wrote: > On Thu, Sep 20, 2012 at 11:40:17AM +0200, Ingo Molnar wrote: > > > Could be moved into a separate file as well - we could have > > arch/x86/kprobes/, with core.c, opt.c, ftrace.c and common.h > > in it - possibly more in the future. > > So, I'm guessing I should mov

Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

2012-09-20 Thread Borislav Petkov
On Thu, Sep 20, 2012 at 11:40:17AM +0200, Ingo Molnar wrote: > Could be moved into a separate file as well - we could have > arch/x86/kprobes/, with core.c, opt.c, ftrace.c and common.h in it - > possibly more in the future. So, I'm guessing I should move only the function now and let Masami do th

Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

2012-09-20 Thread Ingo Molnar
* Masami Hiramatsu wrote: > (2012/09/20 18:25), Ingo Molnar wrote: > > > > * Masami Hiramatsu wrote: > > > >> (2012/09/19 22:46), Borislav Petkov wrote: > >>> From: Borislav Petkov > >>> > >>> I get > >>> > >>> arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared > >>> ‘sta

Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

2012-09-20 Thread Masami Hiramatsu
(2012/09/20 18:25), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> (2012/09/19 22:46), Borislav Petkov wrote: >>> From: Borislav Petkov >>> >>> I get >>> >>> arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared >>> ‘static’ but never defined [-Wunused-function] >>> >>>

Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

2012-09-20 Thread Ingo Molnar
* Masami Hiramatsu wrote: > (2012/09/19 22:46), Borislav Petkov wrote: > > From: Borislav Petkov > > > > I get > > > > arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared > > ‘static’ but never defined [-Wunused-function] > > > > on tip/auto-latest. > > > > Hide the forwa

Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

2012-09-20 Thread Masami Hiramatsu
(2012/09/19 22:46), Borislav Petkov wrote: > From: Borislav Petkov > > I get > > arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared > ‘static’ but never defined [-Wunused-function] > > on tip/auto-latest. > > Hide the forward declaration in the KPROBES_CAN_USE_FTRACE as it

[PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly

2012-09-19 Thread Borislav Petkov
From: Borislav Petkov I get arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared ‘static’ but never defined [-Wunused-function] on tip/auto-latest. Hide the forward declaration in the KPROBES_CAN_USE_FTRACE as it is done in its callsites. Cc: Masami Hiramatsu Cc: Steven Ros