Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-26 Thread Marcelo Tosatti
On Mon, Nov 26, 2012 at 03:49:36PM -0800, H. Peter Anvin wrote: > On 11/26/2012 03:48 PM, Marcelo Tosatti wrote: > >> > >> Gleb, Marcelo: are you going to apply this or would you prefer I took it > >> in x86/urgent? > >> > >>-hpa > > > > Feel free to merge it through x86/urgent. > > > > I

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-26 Thread H. Peter Anvin
On 11/26/2012 03:48 PM, Marcelo Tosatti wrote: >> >> Gleb, Marcelo: are you going to apply this or would you prefer I took it >> in x86/urgent? >> >> -hpa > > Feel free to merge it through x86/urgent. > I presume that's an Acked-by? -hpa -- To unsubscribe from this list: send the

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-26 Thread Marcelo Tosatti
On Mon, Nov 26, 2012 at 02:48:50PM -0800, H. Peter Anvin wrote: > On 11/25/2012 11:22 PM, Paolo Bonzini wrote: > > Il 21/11/2012 23:41, H. Peter Anvin ha scritto: > >> From: "H. Peter Anvin" > >> > >> In __emulate_1op_rax_rdx, we use "+a" and "+d" which are input/output > >> constraints, and

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-26 Thread H. Peter Anvin
On 11/25/2012 11:22 PM, Paolo Bonzini wrote: > Il 21/11/2012 23:41, H. Peter Anvin ha scritto: >> From: "H. Peter Anvin" >> >> In __emulate_1op_rax_rdx, we use "+a" and "+d" which are input/output >> constraints, and *then* use "a" and "d" as input constraints. This is >> incorrect, but happens

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-26 Thread H. Peter Anvin
On 11/25/2012 11:22 PM, Paolo Bonzini wrote: Il 21/11/2012 23:41, H. Peter Anvin ha scritto: From: H. Peter Anvin h...@linux.intel.com In __emulate_1op_rax_rdx, we use +a and +d which are input/output constraints, and *then* use a and d as input constraints. This is incorrect, but happens

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-26 Thread Marcelo Tosatti
On Mon, Nov 26, 2012 at 02:48:50PM -0800, H. Peter Anvin wrote: On 11/25/2012 11:22 PM, Paolo Bonzini wrote: Il 21/11/2012 23:41, H. Peter Anvin ha scritto: From: H. Peter Anvin h...@linux.intel.com In __emulate_1op_rax_rdx, we use +a and +d which are input/output constraints, and

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-26 Thread H. Peter Anvin
On 11/26/2012 03:48 PM, Marcelo Tosatti wrote: Gleb, Marcelo: are you going to apply this or would you prefer I took it in x86/urgent? -hpa Feel free to merge it through x86/urgent. I presume that's an Acked-by? -hpa -- To unsubscribe from this list: send the line

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-26 Thread Marcelo Tosatti
On Mon, Nov 26, 2012 at 03:49:36PM -0800, H. Peter Anvin wrote: On 11/26/2012 03:48 PM, Marcelo Tosatti wrote: Gleb, Marcelo: are you going to apply this or would you prefer I took it in x86/urgent? -hpa Feel free to merge it through x86/urgent. I presume that's an

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-25 Thread Paolo Bonzini
Il 21/11/2012 23:41, H. Peter Anvin ha scritto: > From: "H. Peter Anvin" > > In __emulate_1op_rax_rdx, we use "+a" and "+d" which are input/output > constraints, and *then* use "a" and "d" as input constraints. This is > incorrect, but happens to work on some versions of gcc. > > However, it

Re: [PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-25 Thread Paolo Bonzini
Il 21/11/2012 23:41, H. Peter Anvin ha scritto: From: H. Peter Anvin h...@linux.intel.com In __emulate_1op_rax_rdx, we use +a and +d which are input/output constraints, and *then* use a and d as input constraints. This is incorrect, but happens to work on some versions of gcc. However,

[PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-22 Thread H. Peter Anvin
From: "H. Peter Anvin" In __emulate_1op_rax_rdx, we use "+a" and "+d" which are input/output constraints, and *then* use "a" and "d" as input constraints. This is incorrect, but happens to work on some versions of gcc. However, it breaks gcc with -O0 and icc, and may break on future versions

[PATCH] x86, kvm: Remove incorrect redundant assembly constraint

2012-11-22 Thread H. Peter Anvin
From: H. Peter Anvin h...@linux.intel.com In __emulate_1op_rax_rdx, we use +a and +d which are input/output constraints, and *then* use a and d as input constraints. This is incorrect, but happens to work on some versions of gcc. However, it breaks gcc with -O0 and icc, and may break on future