Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-12-01 Thread Zhang Rui
On Mon, 2020-11-30 at 20:21 +0100, Thomas Gleixner wrote: > Feng, > > On Fri, Nov 27 2020 at 14:11, Feng Tang wrote: > > On Fri, Nov 27, 2020 at 12:27:34AM +0100, Thomas Gleixner wrote: > > > On Thu, Nov 26 2020 at 09:24, Feng Tang wrote: > > > Yes, that can happen. But OTOH, we should start to

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-12-01 Thread Feng Tang
Hi Thomas, On Mon, Nov 30, 2020 at 08:21:03PM +0100, Thomas Gleixner wrote: > Feng, > > On Fri, Nov 27 2020 at 14:11, Feng Tang wrote: > > On Fri, Nov 27, 2020 at 12:27:34AM +0100, Thomas Gleixner wrote: > >> On Thu, Nov 26 2020 at 09:24, Feng Tang wrote: > >> Yes, that can happen. But OTOH, we

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-30 Thread Thomas Gleixner
Feng, On Fri, Nov 27 2020 at 14:11, Feng Tang wrote: > On Fri, Nov 27, 2020 at 12:27:34AM +0100, Thomas Gleixner wrote: >> On Thu, Nov 26 2020 at 09:24, Feng Tang wrote: >> Yes, that can happen. But OTOH, we should start to think about the >> requirements for using the TSC watchdog. >> >> I'm

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-26 Thread Feng Tang
Hi Thomas, On Fri, Nov 27, 2020 at 12:27:34AM +0100, Thomas Gleixner wrote: > Feng, > > On Thu, Nov 26 2020 at 09:24, Feng Tang wrote: > > On Wed, Nov 25, 2020 at 01:46:23PM +0100, Thomas Gleixner wrote: > >> Now the more interesting question is why this needs to be a PCI quirk in > >> the first

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-26 Thread Thomas Gleixner
Feng, On Thu, Nov 26 2020 at 09:24, Feng Tang wrote: > On Wed, Nov 25, 2020 at 01:46:23PM +0100, Thomas Gleixner wrote: >> Now the more interesting question is why this needs to be a PCI quirk in >> the first place. Can't we just disable the HPET based on family/model >> quirks? >> >>

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-25 Thread Feng Tang
Hi Thomas, On Wed, Nov 25, 2020 at 01:46:23PM +0100, Thomas Gleixner wrote: > On Thu, Nov 19 2020 at 12:19, Bjorn Helgaas wrote: > > 62187910b0fc ("x86/intel: Add quirk to disable HPET for the Baytrail > > platform") implemented force_disable_hpet() as a special early quirk. > > These run before

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-25 Thread Thomas Gleixner
On Wed, Nov 25 2020 at 13:13, Bjorn Helgaas wrote: > On Wed, Nov 25, 2020 at 01:46:23PM +0100, Thomas Gleixner wrote: >> Now the more interesting question is why this needs to be a PCI quirk in >> the first place. Can't we just disable the HPET based on family/model >> quirks? > > You mean like a

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-25 Thread Bjorn Helgaas
On Wed, Nov 25, 2020 at 01:46:23PM +0100, Thomas Gleixner wrote: > On Thu, Nov 19 2020 at 12:19, Bjorn Helgaas wrote: > > 62187910b0fc ("x86/intel: Add quirk to disable HPET for the Baytrail > > platform") implemented force_disable_hpet() as a special early quirk. > > These run before the PCI core

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-25 Thread Thomas Gleixner
On Thu, Nov 19 2020 at 12:19, Bjorn Helgaas wrote: > 62187910b0fc ("x86/intel: Add quirk to disable HPET for the Baytrail > platform") implemented force_disable_hpet() as a special early quirk. > These run before the PCI core is initialized and depend on the > x86/pci/early.c accessors that use

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-24 Thread Bjorn Helgaas
On Thu, Nov 19, 2020 at 12:19:04PM -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > 62187910b0fc ("x86/intel: Add quirk to disable HPET for the Baytrail > platform") implemented force_disable_hpet() as a special early quirk. > These run before the PCI core is initialized and depend on the >

[PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-11-19 Thread Bjorn Helgaas
From: Bjorn Helgaas 62187910b0fc ("x86/intel: Add quirk to disable HPET for the Baytrail platform") implemented force_disable_hpet() as a special early quirk. These run before the PCI core is initialized and depend on the x86/pci/early.c accessors that use I/O ports 0xcf8 and 0xcfc. But