Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-02-04 Thread Ingo Molnar
* Wang, Song-Bo (Stoney) wrote: > * Ingo Molnar wrote: > > > > * Yinghai Lu wrote: > > > > > Please check attached. > > > > Almost good. > > > > This: > > > > > When some HP sytems boot without x2apic_phys, there will be > > > > Should mention the approximate models of the systems aff

RE: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-02-03 Thread Wang, Song-Bo (Stoney)
* Ingo Molnar wrote: > > * Yinghai Lu wrote: > > > Please check attached. > > Almost good. > > This: > > > When some HP sytems boot without x2apic_phys, there will be > > Should mention the approximate models of the systems affected - is it > just a specific line of systems, or a wider r

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-31 Thread Yinghai Lu
On Thu, Jan 31, 2013 at 3:32 AM, Ingo Molnar wrote: > > This: > > > When some HP sytems boot without x2apic_phys, there will be > > Should mention the approximate models of the systems affected - > is it just a specific line of systems, or a wider range of > systems affected? > > This will infor

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-31 Thread Ingo Molnar
* Yinghai Lu wrote: > Please check attached. Almost good. This: > When some HP sytems boot without x2apic_phys, there will be Should mention the approximate models of the systems affected - is it just a specific line of systems, or a wider range of systems affected? This will inform use

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-29 Thread Yinghai Lu
On Tue, Jan 29, 2013 at 12:49 AM, Ingo Molnar wrote: > > * Wang, Song-Bo (Stoney) wrote: > >> [...] Due to this mode mismatch, with specific HW >> configurations, there will be intermittent lost interrupts, >> which could result in a hang or data loss. > > That's the key piece of information that

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-29 Thread Yinghai Lu
On Tue, Jan 29, 2013 at 12:49 AM, Ingo Molnar wrote: > > * Wang, Song-Bo (Stoney) wrote: > >> [...] Due to this mode mismatch, with specific HW >> configurations, there will be intermittent lost interrupts, >> which could result in a hang or data loss. Wang, Maybe off topic, You should never sh

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-29 Thread Ingo Molnar
* Wang, Song-Bo (Stoney) wrote: > [...] Due to this mode mismatch, with specific HW > configurations, there will be intermittent lost interrupts, > which could result in a hang or data loss. That's the key piece of information that was missing - which should be put into the changelog into a

RE: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-29 Thread Wang, Song-Bo (Stoney)
on, Greg; linux- > ker...@vger.kernel.org; suresh.b.sid...@intel.com > Subject: Re: [PATCH] x86/apic: check FADT settings after enable x2apic > > > * Yinghai Lu wrote: > > > On Mon, Jan 28, 2013 at 2:11 AM, Ingo Molnar wrote: > > > > > >> HP has systems that work w

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-28 Thread Ingo Molnar
* Yinghai Lu wrote: > On Mon, Jan 28, 2013 at 2:11 AM, Ingo Molnar wrote: > > > >> HP has systems that work with x2apic phys mode and BIOS set > >> ACPI_FADT_APIC_PHYSICAL in FADT table, and all cpuid < 255, > >> the spec requires BIOS only put system on xapic mode. Kernel > > > > Which spec? >

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-28 Thread Yinghai Lu
On Mon, Jan 28, 2013 at 2:11 AM, Ingo Molnar wrote: > >> HP has systems that work with x2apic phys mode and BIOS set >> ACPI_FADT_APIC_PHYSICAL in FADT table, and all cpuid < 255, >> the spec requires BIOS only put system on xapic mode. Kernel > > Which spec? > >> will set to x2apic logical mode i

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-28 Thread Ingo Molnar
* Yinghai Lu wrote: > On Sun, Jan 27, 2013 at 9:05 PM, Wang, Song-Bo (Stoney) > wrote: > > Hi Yinghai, hpa and others, > > > > Would you please review the patch on detecting x2apic FADT settings? > > > > We meet a BIOS system which works on x2apic physical mode by > > setting the bit ACPI_FADT

Re: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-27 Thread Yinghai Lu
On Sun, Jan 27, 2013 at 9:05 PM, Wang, Song-Bo (Stoney) wrote: > Hi Yinghai, hpa and others, > > Would you please review the patch on detecting x2apic FADT settings? > > We meet a BIOS system which works on x2apic physical mode by setting the bit > ACPI_FADT_APIC_PHYSICAL in FADT table. > And for

RE: [PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-27 Thread Wang, Song-Bo (Stoney)
: suresh.b.sid...@intel.com Cc: Zhang, Lin-Bao (Linux Kernel R&D); Pearson, Greg; linux-kernel@vger.kernel.org; Wang, Song-Bo (Stoney) Subject: [PATCH] x86/apic: check FADT settings after enable x2apic OS will enable x2apic mode even BIOS default in xapic mode. FADT sett

[PATCH] x86/apic: check FADT settings after enable x2apic

2013-01-14 Thread Stoney Wang
OS will enable x2apic mode even BIOS default in xapic mode. FADT settings check (commit ea0dcf903e7d76aa5d483d876215fedcfdfe140f) should be applied after detect default mode and change the mode (enable_IR_x2apic called) Signed-off-by: Stoney Wang --- arch/x86/kernel/apic/x2apic_phys.c | 25 +