Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-29 Thread Arnd Bergmann
On Fri, Sep 29, 2017 at 12:51 AM, Ingo Molnar wrote: > > * Linus Torvalds wrote: > >> On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: >> The kernel test robot report looked to be ignored as a "gcc-4.4 is too >> old to

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-29 Thread Arnd Bergmann
On Fri, Sep 29, 2017 at 12:51 AM, Ingo Molnar wrote: > > * Linus Torvalds wrote: > >> On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: >> The kernel test robot report looked to be ignored as a "gcc-4.4 is too >> old to worry about" thing. [...] > > No, and sorry if my first reply

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-29 Thread Ye Xiaolong
On 09/29, Ingo Molnar wrote: > >* Josh Poimboeuf wrote: > >> On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: >> > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf >> > wrote: >> > > >> > > Reported-by: kernel test robot

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-29 Thread Ye Xiaolong
On 09/29, Ingo Molnar wrote: > >* Josh Poimboeuf wrote: > >> On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: >> > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf >> > wrote: >> > > >> > > Reported-by: kernel test robot >> > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-29 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > > > > > Reported-by: kernel test robot > > > Fixes: f5caf621ee35 ("x86/asm:

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-29 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > > > > > Reported-by: kernel test robot > > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > > > Signed-off-by:

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-29 Thread Ingo Molnar
* Linus Torvalds wrote: > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > > > Reported-by: kernel test robot > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > > Signed-off-by:

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-29 Thread Ingo Molnar
* Linus Torvalds wrote: > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > > > Reported-by: kernel test robot > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > > Signed-off-by: Josh Poimboeuf > > Side note: it's not like I personally need the credit,

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-28 Thread Josh Poimboeuf
On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > > > Reported-by: kernel test robot > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > >

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-28 Thread Josh Poimboeuf
On Thu, Sep 28, 2017 at 04:53:09PM -0700, Linus Torvalds wrote: > On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > > > Reported-by: kernel test robot > > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > > Signed-off-by: Josh Poimboeuf > > Side note: it's

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-28 Thread Linus Torvalds
On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > Reported-by: kernel test robot > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > Signed-off-by: Josh Poimboeuf Side note: it's not like I

Re: [PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-28 Thread Linus Torvalds
On Thu, Sep 28, 2017 at 2:58 PM, Josh Poimboeuf wrote: > > Reported-by: kernel test robot > Fixes: f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") > Signed-off-by: Josh Poimboeuf Side note: it's not like I personally need the credit, but in general I really want people to

[PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-28 Thread Josh Poimboeuf
The kernel test bot reported that f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") is causing double faults in a kernel compiled with GCC 4.4. The issue is with this code: register unsigned int __asm_call_sp asm("esp"); #define ASM_CALL_CONSTRAINT "+r" (__asm_call_sp)

[PATCH] x86/asm: Fix inline asm call constraints for GCC 4.4

2017-09-28 Thread Josh Poimboeuf
The kernel test bot reported that f5caf621ee35 ("x86/asm: Fix inline asm call constraints for Clang") is causing double faults in a kernel compiled with GCC 4.4. The issue is with this code: register unsigned int __asm_call_sp asm("esp"); #define ASM_CALL_CONSTRAINT "+r" (__asm_call_sp)