Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-10 Thread Baoquan He
On 02/27/19 at 08:39am, Borislav Petkov wrote: > + Kees. > > @Kees, you might want to go upthread a bit for context. > > On Wed, Feb 27, 2019 at 09:30:34AM +0800, Baoquan He wrote: > > Agree that 'crashkernel=x' should be encouraged to use as the first > > choice when reserve crashkernel. If we

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-05 Thread Pingfan Liu
On Wed, Feb 27, 2019 at 3:40 PM Borislav Petkov wrote: > > + Kees. > > @Kees, you might want to go upthread a bit for context. > Seems not reply from Kees. > On Wed, Feb 27, 2019 at 09:30:34AM +0800, Baoquan He wrote: > > Agree that 'crashkernel=x' should be encouraged to use as the first > >

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-26 Thread Borislav Petkov
+ Kees. @Kees, you might want to go upthread a bit for context. On Wed, Feb 27, 2019 at 09:30:34AM +0800, Baoquan He wrote: > Agree that 'crashkernel=x' should be encouraged to use as the first > choice when reserve crashkernel. If we decide to not obsolete > 'crashkernel=x@y', it will leave a

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-26 Thread Baoquan He
On 02/26/19 at 11:46am, Borislav Petkov wrote: > On Tue, Feb 26, 2019 at 11:08:42AM +0800, Pingfan Liu wrote: > > I follow Baoquan's opinion. Due to the randomness caused by KASLR, a > > user may be surprised to find crashkernel=x@y not working sometime. > > And she/he will get told in dmesg that

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-26 Thread Borislav Petkov
On Tue, Feb 26, 2019 at 11:08:42AM +0800, Pingfan Liu wrote: > I follow Baoquan's opinion. Due to the randomness caused by KASLR, a > user may be surprised to find crashkernel=x@y not working sometime. And she/he will get told in dmesg that the allocation failed. > If kernel can help them out of

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-25 Thread Dave Young
On 02/25/19 at 09:05pm, Baoquan He wrote: > On 02/25/19 at 10:45am, Borislav Petkov wrote: > > On Mon, Feb 25, 2019 at 03:59:56PM +0800, Pingfan Liu wrote: > > > crashkernel=x@y option may fail to reserve the required memory region if > > > KASLR puts kernel into the region. To avoid this

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-25 Thread Pingfan Liu
On Mon, Feb 25, 2019 at 4:23 PM Chao Fan wrote: > > On Mon, Feb 25, 2019 at 03:59:56PM +0800, Pingfan Liu wrote: > >crashkernel=x@y option may fail to reserve the required memory region if > >KASLR puts kernel into the region. To avoid this uncertainty, making KASLR > >skip the required region. >

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-25 Thread Pingfan Liu
On Mon, Feb 25, 2019 at 5:45 PM Borislav Petkov wrote: > > On Mon, Feb 25, 2019 at 03:59:56PM +0800, Pingfan Liu wrote: > > crashkernel=x@y option may fail to reserve the required memory region if > > KASLR puts kernel into the region. To avoid this uncertainty, making KASLR > > skip the required

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-25 Thread Baoquan He
On 02/25/19 at 10:45am, Borislav Petkov wrote: > On Mon, Feb 25, 2019 at 03:59:56PM +0800, Pingfan Liu wrote: > > crashkernel=x@y option may fail to reserve the required memory region if > > KASLR puts kernel into the region. To avoid this uncertainty, making KASLR > > skip the required region. >

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-25 Thread Borislav Petkov
On Mon, Feb 25, 2019 at 03:59:56PM +0800, Pingfan Liu wrote: > crashkernel=x@y option may fail to reserve the required memory region if > KASLR puts kernel into the region. To avoid this uncertainty, making KASLR > skip the required region. Lemme see if I understand this correctly: supplying

Re: [PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-25 Thread Chao Fan
On Mon, Feb 25, 2019 at 03:59:56PM +0800, Pingfan Liu wrote: >crashkernel=x@y option may fail to reserve the required memory region if >KASLR puts kernel into the region. To avoid this uncertainty, making KASLR >skip the required region. > >Signed-off-by: Pingfan Liu >Cc: Thomas Gleixner >Cc:

[PATCH] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-02-25 Thread Pingfan Liu
crashkernel=x@y option may fail to reserve the required memory region if KASLR puts kernel into the region. To avoid this uncertainty, making KASLR skip the required region. Signed-off-by: Pingfan Liu Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: "H. Peter Anvin" Cc: Baoquan He