Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-28 Thread H. Peter Anvin
On 09/26/18 02:08, Borislav Petkov wrote: > On Tue, Sep 25, 2018 at 02:13:16PM -0700, Nick Desaulniers wrote: >> Orthogonally, do you know *why* this Makefile overwrites >> KBUILD_CFLAGS? We take great care to set various compiler flags in >> the top level Makefile, so to reset them lower in the t

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-26 Thread Borislav Petkov
On Tue, Sep 25, 2018 at 02:13:16PM -0700, Nick Desaulniers wrote: > Orthogonally, do you know *why* this Makefile overwrites > KBUILD_CFLAGS? We take great care to set various compiler flags in > the top level Makefile, so to reset them lower in the tree seems > troublesome on first glance. Take

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-26 Thread Borislav Petkov
On Tue, Sep 25, 2018 at 02:08:04PM -0700, Nick Desaulniers wrote: > so this is hidden from GCC. I can include this information in the > commit message for a v2 if you'd like? Yes please - in a condensed form. But explaining what happens makes it much more clear, thanks for taking the time. >

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-25 Thread Nick Desaulniers
On Tue, Sep 25, 2018 at 2:08 PM Nick Desaulniers wrote: > > On Tue, Sep 25, 2018 at 12:08 PM Borislav Petkov wrote: > > > > On Tue, Sep 25, 2018 at 11:41:19AM -0700, Nick Desaulniers wrote: > > > bumping for review. > > > > > > On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers > > > wrote: > > >

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-25 Thread Nick Desaulniers
On Tue, Sep 25, 2018 at 12:08 PM Borislav Petkov wrote: > > On Tue, Sep 25, 2018 at 11:41:19AM -0700, Nick Desaulniers wrote: > > bumping for review. > > > > On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers > > wrote: > > > > > > Since this file steamrolls KBUILD_CFLAGS, we have to redefine these

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-25 Thread Borislav Petkov
On Tue, Sep 25, 2018 at 11:41:19AM -0700, Nick Desaulniers wrote: > bumping for review. > > On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers > wrote: > > > > Since this file steamrolls KBUILD_CFLAGS, we have to redefine these > > symbols. Why do we have to redefine these symbols? I don't see ar

Re: [PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-25 Thread Nick Desaulniers
bumping for review. On Fri, Sep 7, 2018 at 1:26 PM Nick Desaulniers wrote: > > Since this file steamrolls KBUILD_CFLAGS, we have to redefine these > symbols. This will prevent warnings in source files in this directory > when Clang supports asm goto. > > Signed-off-by: Nick Desaulniers > --- >

[PATCH] x86/boot: define CC_HAVE_ASM_GOTO

2018-09-07 Thread Nick Desaulniers
Since this file steamrolls KBUILD_CFLAGS, we have to redefine these symbols. This will prevent warnings in source files in this directory when Clang supports asm goto. Signed-off-by: Nick Desaulniers --- arch/x86/boot/compressed/Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a