Re: [PATCH] x86/cpufeature: drop *_MASK_CEHCK

2019-08-27 Thread Cao jin
On 8/28/19 1:20 AM, Borislav Petkov wrote: > On Tue, Aug 27, 2019 at 09:33:11AM -0700, Dave Hansen wrote: >> The point was that there are 5 files in the code that need to be changed >> if you change NCAPINTS: >> >> 1. arch/x86/include/asm/required-features.h >> 2. arch/x86/include/asm/disabled-feat

Re: [PATCH] x86/cpufeature: drop *_MASK_CEHCK

2019-08-27 Thread Borislav Petkov
On Tue, Aug 27, 2019 at 09:33:11AM -0700, Dave Hansen wrote: > The point was that there are 5 files in the code that need to be changed > if you change NCAPINTS: > > 1. arch/x86/include/asm/required-features.h > 2. arch/x86/include/asm/disabled-features.h > 3. tools/arch/x86/include/asm/disabled-f

Re: [PATCH] x86/cpufeature: drop *_MASK_CEHCK

2019-08-27 Thread Dave Hansen
On 8/27/19 12:41 AM, Borislav Petkov wrote: >> #define DISABLED_MASK_BIT_SET(feature_bit) \ >> @@ -104,7 +103,6 @@ extern const char * const x86_bug_flags[NBUGINTS*32]; >> CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 16, feature_bit) ||\ >> CHECK_BIT_IN_MASK_W

Re: [PATCH] x86/cpufeature: drop *_MASK_CEHCK

2019-08-27 Thread Borislav Petkov
On Tue, Aug 27, 2019 at 03:05:50PM +0800, Cao jin wrote: > They are wrappers of BUILD_BUG_ON_ZERO(NCAPINTS != n), which is already > present in corresponding *_MASK_BIT_SET. And fill the missing period in > head comments by the way. > > Signed-off-by: Cao jin > --- > arch/x86/include/asm/cpufeat

[PATCH] x86/cpufeature: drop *_MASK_CEHCK

2019-08-27 Thread Cao jin
They are wrappers of BUILD_BUG_ON_ZERO(NCAPINTS != n), which is already present in corresponding *_MASK_BIT_SET. And fill the missing period in head comments by the way. Signed-off-by: Cao jin --- arch/x86/include/asm/cpufeature.h| 2 -- arch/x86/include/asm/disabled-features.h | 1 - ar