Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

2024-07-31 Thread Huang, Kai
On Wed, 2024-07-31 at 11:22 +0800, WangYuli wrote: > On 2024/7/30 19:57, Huang, Kai wrote: > > > +linux-sgx list, Jarkko, Haitao. > > > > This message is only printed when SGX is reported in CPUID but is not > > enabled in the FEAT_CTL MSR. I can only recall this can happen when the > > BIOS act

Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

2024-07-30 Thread WangYuli
On 2024/7/31 06:48, Huang, Kai wrote: FWIW, this could easily happen with a virtual machine, e.g. running an old QEMU with `-cpu host`. Hmm.. it appears so, if the old Qemu doesn't have SGX support. Thanks. Perhaps "SGX disabled or unsupported by BIOS." or "SGX not enabled by BIOS" is slight

Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

2024-07-30 Thread WangYuli
On 2024/7/30 19:57, Huang, Kai wrote: +linux-sgx list, Jarkko, Haitao. This message is only printed when SGX is reported in CPUID but is not enabled in the FEAT_CTL MSR. I can only recall this can happen when the BIOS actually provides an option for the user to turn on/off SGX, in which case t

Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

2024-07-30 Thread Huang, Kai
On Tue, 2024-07-30 at 10:56 -0700, Sean Christopherson wrote: > On Tue, Jul 30, 2024, Kai Huang wrote: > > On Tue, 2024-07-30 at 10:49 +0800, WangYuli wrote: > > > When SGX is not supported by the BIOS, we still output the error > > > 'SGX disabled by BIOS', which can be confusing since there might

Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

2024-07-30 Thread Sean Christopherson
On Tue, Jul 30, 2024, Kai Huang wrote: > On Tue, 2024-07-30 at 10:49 +0800, WangYuli wrote: > > When SGX is not supported by the BIOS, we still output the error > > 'SGX disabled by BIOS', which can be confusing since there might not be > > an SGX-related option in the BIOS settings. > > +linux-sg

Re: [PATCH] x86/cpufeatures: SGX: Adjust the error message when BIOS does not support SGX

2024-07-30 Thread Huang, Kai
On Tue, 2024-07-30 at 10:49 +0800, WangYuli wrote: > When SGX is not supported by the BIOS, we still output the error > 'SGX disabled by BIOS', which can be confusing since there might not be > an SGX-related option in the BIOS settings. +linux-sgx list, Jarkko, Haitao. This message is only print