Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread Andy Lutomirski
On Tue, Mar 8, 2016 at 10:59 AM, H. Peter Anvin wrote: > On 03/08/16 10:50, Andy Lutomirski wrote: >> On Tue, Mar 8, 2016 at 10:47 AM, H. Peter Anvin wrote: >>> On 03/08/16 10:45, Andy Lutomirski wrote: s/modern/most, perhaps? I'm hoping that some day Bionic goes away and gets

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread H. Peter Anvin
On 03/08/16 10:50, Andy Lutomirski wrote: > On Tue, Mar 8, 2016 at 10:47 AM, H. Peter Anvin wrote: >> On 03/08/16 10:45, Andy Lutomirski wrote: >>> >>> s/modern/most, perhaps? >>> >>> I'm hoping that some day Bionic goes away and gets replaced by musl. >>> >>> Of course, musl doesn't always use fa

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread Andy Lutomirski
On Tue, Mar 8, 2016 at 10:47 AM, H. Peter Anvin wrote: > On 03/08/16 10:45, Andy Lutomirski wrote: >> >> s/modern/most, perhaps? >> >> I'm hoping that some day Bionic goes away and gets replaced by musl. >> >> Of course, musl doesn't always use fast syscalls because it needs a >> vdso facility tha

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread H. Peter Anvin
On 03/08/16 10:45, Andy Lutomirski wrote: > > s/modern/most, perhaps? > > I'm hoping that some day Bionic goes away and gets replaced by musl. > > Of course, musl doesn't always use fast syscalls because it needs a > vdso facility that doesn't currently exist. I'll deal with that > eventually.

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread Andy Lutomirski
On Tue, Mar 8, 2016 at 10:40 AM, H. Peter Anvin wrote: > On 03/08/16 02:30, Ingo Molnar wrote: > + * > + * This is considered a slow path. It is not used by modern libc > + * implementations on modern hardware except during process startup. > + * >>> >>> Sadly I believe Android st

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread H. Peter Anvin
On 03/08/16 02:30, Ingo Molnar wrote: + * + * This is considered a slow path. It is not used by modern libc + * implementations on modern hardware except during process startup. + * >> >> Sadly I believe Android still uses int $0x80 in the upstream version. > > I don't see how

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread Andy Lutomirski
On Mar 8, 2016 2:27 AM, "Ingo Molnar" wrote: > > > * Andy Lutomirski wrote: > > > > > ENTRY(entry_INT80_32) > > > > > > entry_INT80_32() is only used on pure 32-bit kernels, 64-bit kernels use > > > entry_INT80_compat(). So the above text should not talk about 64-bit > > > programs, as > > > th

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread Ingo Molnar
* H. Peter Anvin wrote: > On March 7, 2016 12:22:28 AM PST, Ingo Molnar wrote: > > > >* Andy Lutomirski wrote: > > > >> Ingo suggested that the comments should explain when the various > >> entries are used. This adds these explanations and improves other > >> parts of the comments. > > > >Th

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-08 Thread Ingo Molnar
* Andy Lutomirski wrote: > > > ENTRY(entry_INT80_32) > > > > entry_INT80_32() is only used on pure 32-bit kernels, 64-bit kernels use > > entry_INT80_compat(). So the above text should not talk about 64-bit > > programs, as > > they can never trigger this specific entry point, right? > > > >

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-07 Thread Andy Lutomirski
On Mar 7, 2016 12:22 AM, "Ingo Molnar" wrote: > > > * Andy Lutomirski wrote: > > > Ingo suggested that the comments should explain when the various > > entries are used. This adds these explanations and improves other > > parts of the comments. > > Thanks for doing this, this is really useful! >

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-07 Thread H. Peter Anvin
On March 7, 2016 12:22:28 AM PST, Ingo Molnar wrote: > >* Andy Lutomirski wrote: > >> Ingo suggested that the comments should explain when the various >> entries are used. This adds these explanations and improves other >> parts of the comments. > >Thanks for doing this, this is really useful! >

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-07 Thread Ingo Molnar
* Andy Lutomirski wrote: > Ingo suggested that the comments should explain when the various > entries are used. This adds these explanations and improves other > parts of the comments. Thanks for doing this, this is really useful! One very small detail I noticed: > +/* > + * 32-bit legacy sy

[PATCH] x86/entry: Improve system call entry comments

2016-03-06 Thread Andy Lutomirski
Ingo suggested that the comments should explain when the various entries are used. This adds these explanations and improves other parts of the comments. Signed-off-by: Andy Lutomirski --- This applies on top of all the TF / debug / SYSENTER stuff. If this is too confusing, I'll rebase it and