Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-08 Thread Greg KH
On Wed, May 08, 2019 at 02:28:21PM +0200, Sebastian Gottschall wrote: > so the question is if it isnt possible to create a EXPORT_SYMBOL variant > which includes acceptable license models, but still restricts unacceptable > licenses It's not very difficult, "acceptable" license models are all

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-08 Thread Sebastian Gottschall
Am 07.05.2019 um 12:31 schrieb David Laight: ... So I don't really see a problem with Andy's patch. If we want to annoy external non-GPL modules as much as possible, sure, that's for a separate discussion though (and I am sure many people would agree to that). Proposal to get rid of

RE: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-07 Thread David Laight
... > So I don't really see a problem with Andy's patch. If we want to annoy > external non-GPL modules as much as possible, sure, that's for a separate > discussion though (and I am sure many people would agree to that). > Proposal to get rid of EXPORT_SYMBOL in favor of EXPORT_SYMBOL_GPL would >

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-05 Thread Jiri Kosina
On Sun, 5 May 2019, Rik van Riel wrote: > > Using fpu code in kernel space in a kernel module is a derived work of > > the kernel itself? dont get me wrong, but this is absurd. i mean you > > limit the use of cpu instructions. the use of cpu instructions should > > be free of any licensing

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-05 Thread Rik van Riel
On Sat, 2019-05-04 at 04:28 +0200, Sebastian Gottschall wrote: > Using fpu code in kernel space in a kernel module is a derived work > of > the kernel itself? > dont get me wrong, but this is absurd. i mean you limit the use of > cpu > instructions. the use > of cpu instructions should be free

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-04 Thread Jiri Kosina
On Fri, 3 May 2019, Jiri Kosina wrote: > > Please don't start this. We have everything _GPL that is used for FPU > > related code and only a few functions are exported because KVM needs it. > > That's not completely true. There are a lot of static inlines out there, > which basically made it

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-04 Thread Greg KH
On Sat, May 04, 2019 at 04:28:17AM +0200, Sebastian Gottschall wrote: > > Am 04.05.2019 um 02:47 schrieb Ingo Molnar: > > * Jiri Kosina wrote: > > > > > On Thu, 2 May 2019, Sebastian Andrzej Siewior wrote: > > > > > > > Please don't start this. We have everything _GPL that is used for FPU > >

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-03 Thread Sebastian Gottschall
Am 04.05.2019 um 02:47 schrieb Ingo Molnar: * Jiri Kosina wrote: On Thu, 2 May 2019, Sebastian Andrzej Siewior wrote: Please don't start this. We have everything _GPL that is used for FPU related code and only a few functions are exported because KVM needs it. That's not completely true.

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-03 Thread Ingo Molnar
* Jiri Kosina wrote: > On Thu, 2 May 2019, Sebastian Andrzej Siewior wrote: > > > Please don't start this. We have everything _GPL that is used for FPU > > related code and only a few functions are exported because KVM needs it. > > That's not completely true. There are a lot of static

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-03 Thread Borislav Petkov
On Fri, May 03, 2019 at 11:54:54AM -0700, Andy Lutomirski wrote: > I don’t think I or has said we should try to make these interfaces > immutable. How else would you have a stable interface for OOT modules? If at all, that is. > What I’m saying is that, since we’re exporting the symbol anyway >

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-03 Thread Andy Lutomirski
> On May 3, 2019, at 11:07 AM, Borislav Petkov wrote: > >> On Fri, May 03, 2019 at 11:21:15AM -0600, Paolo Bonzini wrote: >> Your observation that the API only exists on x86 and s390 has no bearing >> to whether the functions should be EXPORT_SYMBOL_GPL or EXPORT_SYMBOL. >> ARM has

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-03 Thread Jiri Kosina
On Thu, 2 May 2019, Sebastian Andrzej Siewior wrote: > Please don't start this. We have everything _GPL that is used for FPU > related code and only a few functions are exported because KVM needs it. That's not completely true. There are a lot of static inlines out there, which basically made

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-03 Thread Borislav Petkov
On Fri, May 03, 2019 at 11:21:15AM -0600, Paolo Bonzini wrote: > Your observation that the API only exists on x86 and s390 has no bearing > to whether the functions should be EXPORT_SYMBOL_GPL or EXPORT_SYMBOL. > ARM has kernel_neon_begin/end, PPC has enable/disable_kernel_altivec. > It's just

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-03 Thread Paolo Bonzini
On 02/05/19 10:55, Borislav Petkov wrote: > On Thu, May 02, 2019 at 09:29:01AM -0700, Andy Lutomirski wrote: >> I'm not saying that we should export things for ZFS's benefit. But, >> as far as I know, _GPL means "this interface is sufficiently specific >> to Linux details that we think that any

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-02 Thread Borislav Petkov
On Thu, May 02, 2019 at 09:29:01AM -0700, Andy Lutomirski wrote: > I'm not saying that we should export things for ZFS's benefit. But, > as far as I know, _GPL means "this interface is sufficiently specific > to Linux details that we think that any user must be a derived work". > I don't think

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-02 Thread Andy Lutomirski
On Thu, May 2, 2019 at 8:41 AM Sebastian Andrzej Siewior wrote: > > On 2019-05-02 07:42:14 [-0700], Andy Lutomirski wrote: > > The FPU is not a super-Linuxy internal detail, so remove the _GPL > > from its export. Without something like this patch, it's impossible > > for even highly

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-02 Thread Sebastian Andrzej Siewior
On 2019-05-02 07:42:14 [-0700], Andy Lutomirski wrote: > The FPU is not a super-Linuxy internal detail, so remove the _GPL > from its export. Without something like this patch, it's impossible > for even highly license-respecting non-GPL modules to use the FPU, > which seems silly to me. After

[PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-02 Thread Andy Lutomirski
The FPU is not a super-Linuxy internal detail, so remove the _GPL from its export. Without something like this patch, it's impossible for even highly license-respecting non-GPL modules to use the FPU, which seems silly to me. After all, the FPU is a CPU feature, not really a kernel feature at