Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-07 Thread Joe Perches
On Tue, 2017-03-07 at 10:01 +0100, Ingo Molnar wrote: > To me a lexical 'true/false' instead of '1/0' is a step backwards in > readability > in many cases What cases are those to you? I can't think of any case where 1/0 for true/false is "more readable" for boolean returns to me.

Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-07 Thread Joe Perches
On Tue, 2017-03-07 at 10:01 +0100, Ingo Molnar wrote: > To me a lexical 'true/false' instead of '1/0' is a step backwards in > readability > in many cases What cases are those to you? I can't think of any case where 1/0 for true/false is "more readable" for boolean returns to me.

Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-07 Thread Ingo Molnar
(Linus and Andrew Cc:-ed) * Thomas Gleixner wrote: > On Tue, 7 Mar 2017, Ingo Molnar wrote: > > > > * kbuild test robot wrote: > > > > > arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function > > > 'xfeatures_mxcsr_quirk' with

Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-07 Thread Ingo Molnar
(Linus and Andrew Cc:-ed) * Thomas Gleixner wrote: > On Tue, 7 Mar 2017, Ingo Molnar wrote: > > > > * kbuild test robot wrote: > > > > > arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function > > > 'xfeatures_mxcsr_quirk' with return type bool > > > > > > Return

Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-07 Thread Thomas Gleixner
On Tue, 7 Mar 2017, Ingo Molnar wrote: > > * kbuild test robot wrote: > > > arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function > > 'xfeatures_mxcsr_quirk' with return type bool > > > > Return statements in functions returning bool should use > >

Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-07 Thread Thomas Gleixner
On Tue, 7 Mar 2017, Ingo Molnar wrote: > > * kbuild test robot wrote: > > > arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function > > 'xfeatures_mxcsr_quirk' with return type bool > > > > Return statements in functions returning bool should use > > true/false instead of

Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-06 Thread Ingo Molnar
* kbuild test robot wrote: > arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function > 'xfeatures_mxcsr_quirk' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. Note that this is a

Re: [PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-06 Thread Ingo Molnar
* kbuild test robot wrote: > arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function > 'xfeatures_mxcsr_quirk' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. Note that this is a totally bogus warning. I

[PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-05 Thread kbuild test robot
arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function 'xfeatures_mxcsr_quirk' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Rik van Riel

[PATCH] x86/fpu: fix boolreturn.cocci warnings

2017-03-05 Thread kbuild test robot
arch/x86/kernel/fpu/xstate.c:931:9-10: WARNING: return of 0/1 in function 'xfeatures_mxcsr_quirk' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Rik van Riel Signed-off-by: